Closed Bug 1290229 Opened 8 years ago Closed 8 years ago

Bug 1285541 broke sndio backend

Categories

(Core :: Audio/Video: cubeb, defect, P2)

Product:
Core
Component:
Audio/Video: cubeb
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox50 --- affected

People

(Reporter: gaston, Assigned: gaston)

References

Details

Attachments

(1 file)

bug-1290229
(deleted), patch
padenot
: review+
Details | Diff | Splinter Review
12:33.45 /home/dusk/home/buildslave-amd64/mozilla-central-amd64/build/media/libcubeb/src/cubeb_sndio.c:293:4: error: use of undeclared identifier 'latency' sadface... and pretty sure its going to migrate to aurora as is..
Blocks: 1285541
So what replaces latency, latency_frames everywhere ?
Flags: needinfo?(padenot)
Or it looks like this was a bulldozer search'n'replace here..https://hg.mozilla.org/integration/mozilla-inbound/rev/0173124d4d31#l13.47 latency_ms was a method parameter.
> static int > sndio_get_min_latency(cubeb * ctx, cubeb_stream_params params, uint32_t * latency_ms) > { > // XXX Not yet implemented. >- *latency = 2048; >+ *latency_ms = 2048; This fixes the build issue.. dunno if that's the 'best' fix.
yeah, latency_frames everywhere, sorry about that.
Flags: needinfo?(padenot)
Attached patch bug-1290229 (deleted) — — Splinter Review
Assignee: nobody → landry
Attachment #8775913 - Flags: review?(padenot)
gaston, I'll upstream this. We're in the process of uplifting our copy of cubeb from upstream.
Attachment #8775913 - Flags: review?(padenot) → review+
So should i set c-n and it lands in m-i or should wait for a uplift from github ?
We'll land it for you today on m-c with all other cubeb changes.
Rank: 25
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: