Closed
Bug 1290233
Opened 8 years ago
Closed 8 years ago
replace uses of nsIXULChromeRegistry
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox51 fixed)
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
The inspector uses nsIXULChromeRegistry in a couple of spots, to see whether the locale is RTL. These uses have to be replaced for de-chrome-ification.
Updated•8 years ago
|
Whiteboard: [devtools-html] → [devtools-html] [triage]
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [reserve-html]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
The use in computed.js doesn't seem needed at all. The one in layout.js might or might not be; but it doesn't seem to affect the test results if I remove it.
Updated•8 years ago
|
Iteration: --- → 51.1 - Aug 15
Priority: P2 → P1
Updated•8 years ago
|
Iteration: 51.1 - Aug 15 → 51.2 - Aug 29
Assignee | ||
Comment 2•8 years ago
|
||
Experiments with the Force RTL add-on show that this code isn't needed.
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8782018 [details] Bug 1290233 - remove uses of nsIXULChromeRegistry from inspector; https://reviewboard.mozilla.org/r/72308/#review69978 Sweet, one more require("chrome") gone.
Attachment #8782018 -
Flags: review?(gtatum) → review+
Assignee | ||
Comment 5•8 years ago
|
||
A bit too eager on the chrome removals somehow, one of those was still needed, until the clipboard changes land.
Comment hidden (mozreview-request) |
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9276295f33de remove uses of nsIXULChromeRegistry from inspector; r=gregtatum
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9276295f33de
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•