The sourcemapped locations for Windows host or development are not parsed properly. Expected Result: You should only see the file name in the location. Observed Result: You see the whole url instead of the file name in the location.

In the initial source map work, the location parsing for Windows not implemented. I have tested it in a Windows environment visually. This is a very minor change so a try run might not be needed, but I can do it when I follow up on your review suggestions.

Comment on attachment 8776084 [details] [diff] [review] 1290527.patch Review of attachment 8776084 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/shared/components/frame.js @@ +191,5 @@ > displaySource : > displaySource.slice(displaySource.lastIndexOf("/") + 1); > + displaySource = displaySource.lastIndexOf("\\") < 0 ? > + displaySource : > + displaySource.slice(displaySource.lastIndexOf("\\") + 1); We should probably add these formatters to a frame utils method or something, also so we can easily test it. Since these are sourcemapped locations, they really can be any sort of representation (doesn't have to be "URL" like or file system like at all), and we're just trying to do our best to display it nicely, so maybe a 'format source map path' utility would be helpful (and for testing)

Forgot to mention that this is a good approach, nice find! Other than moving the two formatters here to a frame utils file (maybe there's a better place?), once we add a test to it (there are tests for frame-utils), should be good for a quick r+!

As per your comments, I moved the two file name formatters to a method in source-utils and added tests for the same.

Comment on attachment 8776294 [details] [diff] [review] 1290527.patch [1.0] Review of attachment 8776294 [details] [diff] [review]: ----------------------------------------------------------------- A few nits, but looks good! r+ ::: devtools/client/shared/source-utils.js @@ +308,5 @@ > + */ > +function getSourceMappedFile(source) { > + // If sourcemapped source is a OSX path, return > + // the characters after last "/". > + source = source.lastIndexOf("/") < 0 ? These should probably be if conditionals rather than ternary ops at this point (both unix and windows) ::: devtools/client/shared/test/unit/test_source-utils.js @@ +153,5 @@ > }); > > +// Test for source mapped file name > +add_task(function* () { > + const { getSourceMappedFile } = sourceUtils; We should add a normal case of some string returning the same value just as a base case

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/6981e2d0a09f Fix a parsing issue for sourcemapped locations on Windows. r=jsantell

I have successfully reproduce this bug on firefox nightly 50.0a1 (2016-07-29) with windows 7 (32 bit) Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0 I found this fix on latest nightly 51.0a1 (2016-08-14) Mozilla/5.0 (Windows NT 6.1; rv:51.0) Gecko/20100101 Firefox/51.0 Build ID : 20160814030203 [testday-20160812]