Closed
Bug 129054
Opened 23 years ago
Closed 21 years ago
saving files to root dir doesn't save related items
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
INVALID
mozilla1.5alpha
People
(Reporter: Brade, Assigned: Brade)
References
Details
(Keywords: dataloss, regression, Whiteboard: [adt3])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Brade
:
review+
|
Details | Diff | Splinter Review |
The composer saving code has a bug in it:
it does: parentDir = tempLocalFile.parent;
However, nsILocalFile's "parent" is null if it's at the root.
If this is the case we should make an nsIURI that points to the root so related
files are saved there as intended.
Comment 1•23 years ago
|
||
nsILocalFile's parent _should_ be null at the root. See bug 121489
Assignee | ||
Comment 3•23 years ago
|
||
this is a huge inconsistency, we should try to fix for 1.0
Status: NEW → ASSIGNED
Keywords: nsbeta1,
regression
Whiteboard: EDITORBASE
Target Milestone: --- → mozilla1.0
Doesn't have anything to do with core editing of content, EDITORBASE-. But
marking nsbeta1+ since this is a large defect.
Comment 5•23 years ago
|
||
Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.) Thanks!
Assignee | ||
Updated•22 years ago
|
Assignee | ||
Updated•22 years ago
|
Keywords: dataloss
Target Milestone: mozilla1.2alpha → mozilla1.4alpha
Comment 8•22 years ago
|
||
Composer triage team: nsbeta1+/adt2
Whiteboard: EDITORBASE- → [adt2] EDITORBASE-
Comment 9•22 years ago
|
||
By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and
<http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss
bugs are of critical or possibly higher severity. Only changing open bugs to
minimize unnecessary spam. Keywords to trigger this would be crash, topcrash,
topcrash+, zt4newcrash, dataloss.
Severity: normal → critical
Updated•22 years ago
|
Whiteboard: [adt2] EDITORBASE- → [adt2]
Assignee | ||
Updated•22 years ago
|
Target Milestone: mozilla1.4alpha → mozilla1.4beta
Assignee | ||
Comment 11•22 years ago
|
||
Comment 12•22 years ago
|
||
Composer triage: nsbeta1-
Assignee | ||
Comment 13•22 years ago
|
||
I can't reproduce this problem so pushing off to 1.5a (although I think we still
want the patch above)
Target Milestone: mozilla1.4beta → mozilla1.5alpha
Assignee | ||
Comment 14•21 years ago
|
||
Comment on attachment 118400 [details] [diff] [review]
patch to test on windows
I'd like to land this patch (without the dumps) for 1.5a. Requesting reviews
despite called code not working as documented.
Attachment #118400 -
Flags: superreview?(jaggernaut)
Attachment #118400 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 15•21 years ago
|
||
Comment on attachment 118400 [details] [diff] [review]
patch to test on windows
> relatedFilesDir = tempLocalFile.parent; // this is wrong if parent is the root!
>+ // if parent is root dir, we'll have null relatedFilesDir and
>+ // that is not what we want, we want to save files to root
>+ if (!relatedFilesDir)
>+ relatedFilesDir.path = relatedFilesDirStr;
I don't understand this bug. I don't see how you can have a problem getting the
parent of a file (which surely tempLocalFile must be, if you are trying to save
to it). But the fix is wrong anyway, because you're trying to set the .path of
null.
Attachment #118400 -
Flags: review?(neil.parkwaycc.co.uk) → review-
Assignee | ||
Updated•21 years ago
|
Attachment #118400 -
Attachment is obsolete: true
Attachment #118400 -
Flags: superreview?(jaggernaut)
Assignee | ||
Comment 16•21 years ago
|
||
Neil and I agree that removing the bogus comment is the correct thing here and
that this bug should be resolved as invalid.
Assignee | ||
Comment 17•21 years ago
|
||
Comment on attachment 124564 [details] [diff] [review]
remove bogus comment
r=Neil (via irc)
requesting jag's sr= for this comment-only patch.
Attachment #124564 -
Flags: superreview?(jaggernaut)
Attachment #124564 -
Flags: review+
Comment 18•21 years ago
|
||
Comment on attachment 124564 [details] [diff] [review]
remove bogus comment
rs=sspitzer on the comment removal.
Assignee | ||
Comment 19•21 years ago
|
||
resolving as invalid; the current code seems to work as intended
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → INVALID
Assignee | ||
Updated•21 years ago
|
Attachment #124564 -
Flags: superreview?(jaggernaut)
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•