Closed
Bug 1290634
Opened 8 years ago
Closed 8 years ago
CopyTexImage w/ALPHA fails on Core profiles
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(3 files)
We should be using idealUnpack->internalFormat for this.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68118/
Attachment #8776221 -
Flags: review?(mtseng)
Attachment #8776222 -
Flags: review?(mtseng)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68120/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68120/
Assignee | ||
Comment 3•8 years ago
|
||
Green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=32ed67dc408d
The test that checks this is probably disabled.
Comment 4•8 years ago
|
||
Comment on attachment 8776221 [details]
Bug 1290634 - Remove unnecessary respecifyTexture arg from ZeroTextureData. -
https://reviewboard.mozilla.org/r/68118/#review65284
Attachment #8776221 -
Flags: review?(mtseng) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8776222 [details]
Bug 1290634 - Use idealUnpack with CopyTexImage, and always respec now that ZeroTextureData doesn't support respec. -
https://reviewboard.mozilla.org/r/68120/#review65286
Attachment #8776222 -
Flags: review?(mtseng) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b0e54e156e
Remove unnecessary respecifyTexture arg from ZeroTextureData. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7cd5b39cca
Use idealUnpack with CopyTexImage, and always respec now that ZeroTextureData doesn't support respec. - r=mtseng
Comment 7•8 years ago
|
||
backed out for issues like https://treeherder.mozilla.org/logviewer.html#?job_id=33377341&repo=mozilla-inbound
Flags: needinfo?(jgilbert)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6017ae52872
Backed out changeset 4b7cd5b39cca
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc0b9a51656f
Backed out changeset c0b0e54e156e for webgl regressions
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8779830 -
Flags: review?(mtseng) → review?(hshih)
Comment 12•8 years ago
|
||
mozreview-review |
Comment on attachment 8779830 [details]
Bug 1290634 - Handle out-of-bounds copyTexImage on D3D9 ANGLE. -
https://reviewboard.mozilla.org/r/70744/#review68670
Attachment #8779830 -
Flags: review?(hshih) → review+
Comment 13•8 years ago
|
||
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f234bc22c1bf
Remove unnecessary respecifyTexture arg from ZeroTextureData. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bcfbe7fc1e8
Use idealUnpack with CopyTexImage, and always respec now that ZeroTextureData doesn't support respec. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/a658af6ae599
Handle out-of-bounds copyTexImage on D3D9 ANGLE. - r=jerry
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f234bc22c1bf
https://hg.mozilla.org/mozilla-central/rev/1bcfbe7fc1e8
https://hg.mozilla.org/mozilla-central/rev/a658af6ae599
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jgilbert)
You need to log in
before you can comment on or make changes to this bug.
Description
•