Closed Bug 1290634 Opened 8 years ago Closed 8 years ago

CopyTexImage w/ALPHA fails on Core profiles

Categories

(Core :: Graphics: CanvasWebGL, defect)

50 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(3 files)

We should be using idealUnpack->internalFormat for this.
Green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=32ed67dc408d The test that checks this is probably disabled.
Comment on attachment 8776221 [details] Bug 1290634 - Remove unnecessary respecifyTexture arg from ZeroTextureData. - https://reviewboard.mozilla.org/r/68118/#review65284
Attachment #8776221 - Flags: review?(mtseng) → review+
Comment on attachment 8776222 [details] Bug 1290634 - Use idealUnpack with CopyTexImage, and always respec now that ZeroTextureData doesn't support respec. - https://reviewboard.mozilla.org/r/68120/#review65286
Attachment #8776222 - Flags: review?(mtseng) → review+
Blocks: 1291722
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b0e54e156e Remove unnecessary respecifyTexture arg from ZeroTextureData. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7cd5b39cca Use idealUnpack with CopyTexImage, and always respec now that ZeroTextureData doesn't support respec. - r=mtseng
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6017ae52872 Backed out changeset 4b7cd5b39cca https://hg.mozilla.org/integration/mozilla-inbound/rev/bc0b9a51656f Backed out changeset c0b0e54e156e for webgl regressions
Attachment #8779830 - Flags: review?(mtseng) → review?(hshih)
Comment on attachment 8779830 [details] Bug 1290634 - Handle out-of-bounds copyTexImage on D3D9 ANGLE. - https://reviewboard.mozilla.org/r/70744/#review68670
Attachment #8779830 - Flags: review?(hshih) → review+
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f234bc22c1bf Remove unnecessary respecifyTexture arg from ZeroTextureData. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/1bcfbe7fc1e8 Use idealUnpack with CopyTexImage, and always respec now that ZeroTextureData doesn't support respec. - r=mtseng https://hg.mozilla.org/integration/mozilla-inbound/rev/a658af6ae599 Handle out-of-bounds copyTexImage on D3D9 ANGLE. - r=jerry
Flags: needinfo?(jgilbert)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: