Closed Bug 1290644 Opened 8 years ago Closed 8 years ago

Remove VS2010 workarounds in dom/media/

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox49 --- wontfix
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

vs2013-media-workarounds.patch
(deleted), patch
ayang
: review+
Details | Diff | Splinter Review
Attached patch vs2013-media-workarounds.patch (deleted) — — Splinter Review
We no longer support building with VS2013 (bug 1186064) so these workarounds for compiler issues with VS2010 and VS2013 can be removed. Alfredo, you added these workarounds in bug 891704 and bug 1163486.
Attachment #8776247 - Flags: review?(ayang)
Attachment #8776247 - Flags: review?(ayang) → review+
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b32bb2956bbf Remove VS2010 workaround in dom/media/. r=ayang
Thanks. Unfortunately, the VS2013 issue with array initialization in TestMP4Demuxer.cpp still doesn't compile with VS2015, so I only landed the VS2010 change.
status-firefox49: --- → wontfix
status-firefox50: --- → fixed
Summary: Remove VS2010 and VS2013 workarounds in dom/media/ → Remove VS2010 workarounds in dom/media/
https://hg.mozilla.org/mozilla-central/rev/b32bb2956bbf
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: