Closed Bug 1290656 Opened 8 years ago Closed 8 years ago

gbox is not defined in am-im.js

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird49 fixed, thunderbird50 fixed, thunderbird51 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 51.0
Tracking Flags:
Tracking Status
thunderbird49 --- fixed
thunderbird50 --- fixed
thunderbird51 --- fixed

People

(Reporter: aceman, Assigned: aleth)

References

Details

Attachments

(1 file)

Fix undefined gbox regression in am-im.js
(deleted), patch
aceman
: review+
jorgk-bmo
: approval-comm-aurora+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
Found when playing with IM accounts in account manager: ReferenceError: gbox is not defined am-im.js:93
Thanks for the catch! Regression from https://hg.mozilla.org/comm-central/rev/2f6efb061544.
Attachment #8776709 - Flags: review?(acelists)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Regression affects TB47 and newer.
Blocks: 1237385
Comment on attachment 8776709 [details] [diff] [review] Fix undefined gbox regression in am-im.js Review of attachment 8776709 [details] [diff] [review]: ----------------------------------------------------------------- I do not see what has improved now, but the error is no longer there. Thanks.
Attachment #8776709 - Flags: review?(acelists) → review+
https://hg.mozilla.org/comm-central/rev/8f3e3e2129c8d23ce5c38a1bad7b5a8d3eedee60 Bug 1290656 - Fix undefined gbox regression in am-im.js. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
aleth: Do we want to uplift this?
Comment on attachment 8776709 [details] [diff] [review] Fix undefined gbox regression in am-im.js [Approval Request Comment] User impact if declined: Might as well uplift, simple regression fix. Risk to taking this patch (and alternatives if risky): zero
Attachment #8776709 - Flags: approval-comm-beta?
Attachment #8776709 - Flags: approval-comm-aurora?
Attachment #8776709 - Flags: approval-comm-beta?
Attachment #8776709 - Flags: approval-comm-beta+
Attachment #8776709 - Flags: approval-comm-aurora?
Attachment #8776709 - Flags: approval-comm-aurora+
Aurora (TB 50): https://hg.mozilla.org/releases/comm-aurora/rev/63e56e12af64 (pushed with DONTBUILD since I missed it on the previous push).
status-thunderbird49: --- → affected
status-thunderbird50: --- → fixed
status-thunderbird51: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: