Closed
Bug 1291364
Opened 8 years ago
Closed 8 years ago
Worker timeouts can call gray functions and pass gray arguments
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1288770 +++
Just going to do the manual JS::ExposeValueToActiveJS calls for now, so we can land spidermonkey asserts.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8777033 -
Flags: review?(terrence)
|
||
Updated•8 years ago
|
Attachment #8777033 -
Flags: review?(terrence) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2deb6ffa4b55
Make sure workers unmark things gray before passing them to JS_CallFunctionValue when running timeouts. r=terrence
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8777033 [details] [diff] [review]
Make sure workers unmark things gray before passing them to JS_CallFunctionValue when running timeouts
Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: Possible GC crashes and other such badness
[Describe test coverage new/current, TreeHerder]: This codepath is tested in
general, yes.
[Risks and why]: This is extremely low risk.
[String/UUID change made/needed]: None.
Attachment #8777033 -
Flags: approval-mozilla-aurora?
status-firefox50:
--- → affected
Comment on attachment 8777033 [details] [diff] [review]
Make sure workers unmark things gray before passing them to JS_CallFunctionValue when running timeouts
Crash fix, has stabilized on Nightly for a few weeks, Aurora50+
Attachment #8777033 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 6•8 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•