Table headers are not removed when selecting an empty storage
Categories
(DevTools :: Storage Inspector, defect, P2)
Tracking
(firefox51 wontfix, firefox68 verified)
People
(Reporter: sebo, Assigned: avi.mathur.engg+github, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [todo-mr][t1][lang=js])
Attachments
(3 files)
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Reporter | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Reporter | ||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Comment 17•7 years ago
|
||
Reporter | ||
Comment 18•7 years ago
|
||
Updated•6 years ago
|
Comment 19•6 years ago
|
||
This bug has not been updated in the last 6 months. Resetting the assignee field.
Please, feel free to pick it up again and add a comment outlining your plans for it if you do still intend to work on it.
This is just trying to clean our backlog of bugs and make bugs available for people.
Comment 20•6 years ago
|
||
hi, I would like to work on this bug. I am new to this code base and I don't know where to start. Can someone help me to work on this bug?
Assignee | ||
Comment 21•6 years ago
|
||
Hello, I would also like to help with this. If some one can advice where to look for.
Assignee | ||
Comment 22•6 years ago
|
||
Mike I have fixed this bug, please advice me how to proceed ?
(In reply to avi.mathur.engg+github from comment #22)
Mike I have fixed this bug, please advice me how to proceed ?
Hi, so you have fixed the bug and have a patch ready for review? That's great!
Please work through the instructions here to get set up to request a code review.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
In a notshell ():
- Go to https://phabricator.services.mozilla.com/
- Click Log in
- Register and log in.
- Install arc and generate a certificate using
arc install-certificate
- Install moz-phab
- Ensure your patch commit message looks like this:
Bug 1291427 - Table headers are not removed when selecting an empty storage r?mratcliffe
- moz-phab submit <revisionNumber>
If you need any more help you are best to ping me in the #general channel of https://devtools-html.slack.com/
Assignee | ||
Comment 24•6 years ago
|
||
Before this change clicking on Storage Type use to show table headers from previous selection. Now clicking on Storage Type will reset table headers also in case empty table headers will get cleared.
Assignee | ||
Updated•6 years ago
|
Comment 25•6 years ago
|
||
Comment 26•6 years ago
|
||
Backed out changeset c8a4f2586fc0 (bug 1291427) for devtools on browser_storage_cookies_edit.js on a CLOSED TREE
Backout: https://hg.mozilla.org/integration/autoland/rev/d3d719ba069153ae29a99f60ec537133345c7ff0
Failure log:[task 2019-03-08T15:11:58.750Z] 15:11:58 INFO - TEST-PASS | devtools/client/storage/test/browser_storage_cookies_edit.js | value column has the right value for newTest3{9d414cc5-8319-0a04-0586-c0a6ae01670a}test1.example.org{9d414cc5-8319-0a04-0586-c0a6ae01670a}/ -
[task 2019-03-08T15:11:58.751Z] 15:11:58 INFO - Typing true
[task 2019-03-08T15:11:58.752Z] 15:11:58 INFO - Pressing KEY_Enter
[task 2019-03-08T15:11:58.753Z] 15:11:58 INFO - Validating results... waiting for ROW_EDIT event.
[task 2019-03-08T15:11:58.755Z] 15:11:58 INFO - Buffered messages finished
[task 2019-03-08T15:11:58.756Z] 15:11:58 INFO - TEST-UNEXPECTED-FAIL | devtools/client/storage/test/browser_storage_cookies_edit.js | Test timed out -
[task 2019-03-08T15:11:58.759Z] 15:11:58 INFO - GECKO(3030) | ++DOMWINDOW == 16 (0x7f69eec5e400) [pid = 3030] [serial = 78] [outer = 0x7f69ef50c3e0]
[task 2019-03-08T15:11:58.760Z] 15:11:58 INFO - GECKO(3030) | console.warn: "Error while detaching the thread front: 'detach' request packet to 'server1.conn10.child1/context22' can't be sent as the connection is closed."
[task 2019-03-08T15:11:59.192Z] 15:11:59 INFO - Removing tab.
[task 2019-03-08T15:11:59.193Z] 15:11:59 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-03-08T15:11:59.254Z] 15:11:59 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-03-08T15:11:59.290Z] 15:11:59 INFO - Tab removed and finished closing
[task 2019-03-08T15:11:59.372Z] 15:11:59 INFO - GECKO(3030) | MEMORY STAT | vsize 2049MB | residentFast 323MB | heapAllocated 103MB
[task 2019-03-08T15:11:59.376Z] 15:11:59 INFO - TEST-OK | devtools/client/storage/test/browser_storage_cookies_edit.js | took 91507ms
[task 2019-03-08T15:11:59.392Z] 15:11:59 INFO - GECKO(3030) | ++DOCSHELL 0x7fcebe53c800 == 1 [pid = 3187] [id = {d3742d67-5344-49e6-b7f1-f059b8a7eb9b}]
[task 2019-03-08T15:11:59.396Z] 15:11:59 INFO - GECKO(3030) | ++DOMWINDOW == 1 (0x7fcebe9d9d40) [pid = 3187] [serial = 17] [outer = (nil)]
[task 2019-03-08T15:11:59.460Z] 15:11:59 INFO - GECKO(3030) | ++DOMWINDOW == 2 (0x7fcebe583400) [pid = 3187] [serial = 18] [outer = 0x7fcebe9d9d40]
[task 2019-03-08T15:11:59.488Z] 15:11:59 INFO - checking window state
This didn't stay landed for very long, never mind, it happens.
Can you go to Phabricator and address my comment?
Assignee | ||
Comment 29•6 years ago
|
||
Hello Mike, I have made those changes. Please review.
Tried contacting you over IRC however I can't seem to find you. That's why commenting here.
The slack channels you have provided only allows mozilla.com accounts let me know if I can create one to join the slack channel.
Updated•6 years ago
|
Comment 31•6 years ago
|
||
Comment 32•6 years ago
|
||
bugherder |
Reporter | ||
Comment 33•6 years ago
|
||
Looks good to me on Nightly 68.0a1 (2019-03-22). Thank you for fixing this!
Sebastian
Updated•5 years ago
|
Comment 34•5 years ago
|
||
I have reproduced this issue using Firefox 51.0a1 Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 68.0b7 on Win 10 x64, macOS 10.13.6 and Ubuntu 18.04 x64.
Updated•5 years ago
|
Description
•