Closed
Bug 1291618
Opened 8 years ago
Closed 8 years ago
Fix dropmarker position of command-button-frames in RTL locales
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox49 affected, firefox50 affected, firefox51 verified)
People
(Reporter: magicp.jp, Assigned: rickychien, Mentored)
References
Details
(Whiteboard: [reserve-html] [good first bug][good taipei bug][lang=css])
Attachments
(2 files)
command-button-frames-dropmarker-position-in-rtl.png
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160802030437
Steps to reproduce:
1. Start Nightly in RTL locales (e.g. Arabic)
2. Open DevTools
3. Check dropmarker position of command-button-frames
Actual results:
dropmarker position is right side.
Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3a87296fe4145138c2ce15512bb31f76fe869cb4&tochange=42fab251fe111d5f891c9bde0ee1fb6f7f946a50
Expected results:
dropmarker should be left side in RTL locales
Blocks: 1266419
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox50:
--- → affected
status-firefox51:
--- → affected
Component: Untriaged → Developer Tools
OS: Unspecified → All
Hardware: Unspecified → All
|
||
Updated•8 years ago
|
Blocks: devtools-html-2
Flags: qe-verify+
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage]
status-firefox49:
--- → affected
|
||
Updated•8 years ago
|
Mentor: ntim.bugs
Whiteboard: [devtools-html] [triage] → [devtools-html] [triage][good first bug][good taipei bug][lang=css]
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69224/
Attachment #8777713 -
Flags: review?(ntim.bugs)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8777713 [details]
Bug 1291618 - Fix dropmarker position of command-button-frames in RTL locales
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69224/diff/1-2/
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8777713 [details]
Bug 1291618 - Fix dropmarker position of command-button-frames in RTL locales
https://reviewboard.mozilla.org/r/69224/#review66364
Tested and works fine. Thanks!
Attachment #8777713 -
Flags: review?(ntim.bugs) → review+
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
|
|
||
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [devtools-html] [triage][good first bug][good taipei bug][lang=css] → [reserve-html] [good first bug][good taipei bug][lang=css]
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/0636c302f407
Fix dropmarker position of command-button-frames in RTL locales. r=ntim
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
|
||
Updated•8 years ago
|
Iteration: --- → 51.1 - Aug 15
Priority: P3 → P1
|
|
||
Updated•8 years ago
|
QA Contact: adalucin → cristian.comorasu
|
||
Comment 6•8 years ago
|
||
I reproduced this bug using Fx 51.0a1(ar), build ID: 20160802030437, on Windows 10 x64.
I can confirm the bug is fixed, I verified using Fx 51.0a1(ar) build ID: 20160817030202, on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.9.5.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•