Review commit: https://reviewboard.mozilla.org/r/68900/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68900/

Comment on attachment 8777312 [details] Bug 1291657 - run web-platform-tests for linux64 in ubuntu 16.04 vs ubuntu 12.04 [manifest changes]. https://reviewboard.mozilla.org/r/68900/#review66716 ::: testing/web-platform/meta/content-security-policy/object-src/object-src-2_1.html.ini:7 (Diff revision 1) > type: testharness > [Async SWF load test] > - expected: NOTRUN > + expected: > + if (os=="linux") and (version=="Ubuntu 16.04"): PASS > + if (os=="linux") and (version=="Ubuntu 12.04"): NOTRUN > + if not (os=="linux"): NOTRUN Note that this will change the default for other versions of Linux to `PASS` (compared to `NOTRUN` before). It isn't clear if this is better or worse really. ::: testing/web-platform/meta/referrer-policy/no-referrer-when-downgrade/attr-referrer/cross-origin/http-http/img-tag/insecure-protocol.keep-origin-redirect.http.html.ini:4 (Diff revision 1) > [insecure-protocol.keep-origin-redirect.http.html] > type: testharness > - expected: TIMEOUT > + expected: > + if (os=="linux") and (version=="Ubuntu 16.04"): OK I find it very odd that these tests suddenly work in 16.04 but not on any other OS. Do we understand that?

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f3080922905 run web-platform-tests for linux64 in ubuntu 16.04 vs ubuntu 12.04 [manifest changes]. r=jgraham

that was just the manifest changes, what remains is a small patch to run the tests on 16.04 :)

Comment on attachment 8781136 [details] [diff] [review] switch wpt tests to use desktop1604-test Review of attachment 8781136 [details] [diff] [review]: ----------------------------------------------------------------- This is the same patch I wrote in bug 1294538. On a technical level it is correct, so I'm giving r+.

thanks!

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b97908a2c4b5 run web-platform-tests for linux64 in ubuntu 16.04 vs ubuntu 12.04. r=gps