Closed
Bug 1292245
Opened 8 years ago
Closed 8 years ago
clean up some trivial require("chrome") uses
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox51 fixed)
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
There are a couple of trivial require("chrome") removals to be done
in modules required during inspector startup; namely in async-utils.js
and indentation.js. Neither of these imports is actually used.
|
||
Updated•8 years ago
|
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69310/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69310/
Attachment #8777902 -
Flags: review?(gtatum)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8777902 [details] Bug 1292245 - remove some unnecessary imports of chrome from devtools; https://reviewboard.mozilla.org/r/69310/#review66466 LGTM
Attachment #8777902 -
Flags: review?(gtatum) → review+
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/192132a4cbc7 remove some unnecessary imports of chrome from devtools; r=gregtatum
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/192132a4cbc7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•