Chris Peterson [:cpeterson] Reporter
	Description • 8 years ago

To reproduce, run `./mach reftest --disable-e10s <filename>` or replace <filename> with `layout/reftest/reftest.list`.

TEST-UNEXPECTED-FAIL | file:///home/shinglyu/workspace/stylo/gecko-dev/layout/reftests/selection/pseudo-element-of-native-anonymous.html | application terminated with exit code 11
REFTEST PROCESS-CRASH | file:///home/shinglyu/workspace/stylo/gecko-dev/layout/reftests/selection/pseudo-element-of-native-anonymous.html | application crashed [None]

Assertion failure: mSource.IsGeckoRuleNode(), at /files/mozilla/stylo/bb/gecko/layout/style/nsStyleContext.h:325

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 1 • 8 years ago

This boils down to a call to nsRuleNode::HasAuthorSpecifiedValues while looking for the selection style in nsTextFrame.cpp.

I have a patch to move the error we raise in the PresShell to nsRuleNode.

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 2 • 8 years ago

This function, btw, explains why I thought we were missing pseudo-elements.

Returning true here unconditionally makes us not style the element with the native style, which makes it look raw when no styles are used.

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 3 • 8 years ago

The commit message said nsPresShell instead of nsPresContext, sorry.

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 4 • 8 years ago

Nobody ever overrides it.

	Pulsebot
	Comment 5 • 8 years ago

Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f9fc14a57c1
Convert the error from nsPresContext::HasAuthorSpecifiedRules in a warning in nsRuleNode. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d599bb5b2dd
Devirtualize nsPresContext::HasAuthorSpecifiedRules. r=bholley

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9f9fc14a57c1
https://hg.mozilla.org/mozilla-central/rev/0d599bb5b2dd