Closed
Bug 1292452
Opened 8 years ago
Closed 8 years ago
Windows a11y+e10s IA2 Support is Incomplete
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
These interfaces also use arrays but I missed them because they don't use length_is (since they're out params, not inout).
IAccessible2_2
IAccessibleTableCell
IAccessibleHypertext2
Assignee | ||
Updated•8 years ago
|
Summary: Add missing ArrayData to PlatformChild → Windows a11y+e10s IA2 Support is Incomplete
Updated•8 years ago
|
tracking-e10s:
--- → +
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8780626 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8780629 -
Flags: review?(jmathies)
Comment 3•8 years ago
|
||
Comment on attachment 8780626 [details] [diff] [review]
Part 1: Additional arraydata
not a very great review, looking up the 48th method on an interface is ... not easy, but I guess its ok. I'd like to have an explanation of the variant type and argument interface iid stuff, because it strange given give we are using array of IAccessibleHyperLink or something not IUnknown
Attachment #8780626 -
Flags: review?(tbsaunde+mozbugs) → review+
Updated•8 years ago
|
Attachment #8780629 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/00bf09b9870a53e26b3081f112937d98087b8aab
Bug 1292452: Add missing ArrayData to Windows a11y e10s PlatformChild; r=tbsaunde
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd26b9ddef2ce6c9af8b074848601f35e6b6b7bc
Bug 1292452: MainThreadHandoff enhancements to support array outparams in IA2; r=jimm
Comment 5•8 years ago
|
||
Had to back these out to successfully back bug 1268544 out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aea13a7c810545c72e4e6de6b71143505dbd8472
https://hg.mozilla.org/integration/mozilla-inbound/rev/aef7e275cc6dd3246481a6be6cdbd700f24abc64
Flags: needinfo?(aklotz)
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d867848c7e66402e7658a4103964ded227779fc8
Bug 1292452: Add missing ArrayData to Windows a11y e10s PlatformChild; r=tbsaunde
https://hg.mozilla.org/integration/mozilla-inbound/rev/183c29790c23279326021e0f6ea6e2c72fb47fc9
Bug 1292452: MainThreadHandoff enhancements to support array outparams in IA2; r=jimm
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d867848c7e66
https://hg.mozilla.org/mozilla-central/rev/183c29790c23
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(aklotz)
You need to log in
before you can comment on or make changes to this bug.
Description
•