Closed Bug 1292453 Opened 8 years ago Closed 8 years ago

MDSM should enter dormant state when its reader is suspended

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/file/0ba72e8027cfcbcbf3426770ac264a7ade2af090/dom/media/MediaDecoderReader.cpp#l166 The reader queue calls ReleaseMediaResources() to suspend a reader. https://hg.mozilla.org/mozilla-central/file/0ba72e8027cfcbcbf3426770ac264a7ade2af090/dom/media/MediaDecoderReader.h#l105 It says ReadMetadata() needs to be called in order to recover a reader. Therefore, MDSM should enter dormant state when its reader is suspended and exit dormant (which will then call ReadMetadata()) upon reader resume.
Assignee: nobody → jwwang
Blocks: 1292047
Priority: -- → P3
No longer blocks: 1292047
Depends on: 1293572
Attachment #8779686 - Flags: review?(esawin)
Comment on attachment 8779686 [details] Bug 1292453 - MDSM should enter dormant state when its reader is suspended. https://reviewboard.mozilla.org/r/70636/#review68008 Looks good, as long as we don't break the sequence of releasing the decoders first and then resuming the next reader and restore the seek position on resuming.
Attachment #8779686 - Flags: review?(esawin) → review+
Thanks! MDSM's entering/exiting dormant state will not change the suspend status of its reader. However, it is possible to call ReleaseMediaResources() on a resumed reader which is fine. Because we won't crash as long as the number of active decoders is <= the pref value "media.decoder.limit".
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f64f8bc8415f MDSM should enter dormant state when its reader is suspended. r=esawin
Blocks: 1294320
Blocks: 1294345
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: