Closed
Bug 1292633
Opened 8 years ago
Closed 8 years ago
Make Ctrl+Tab panel background more opaque
Categories
(Firefox :: Theme, defect, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 51
People
(Reporter: dao, Assigned: dao)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
mikedeboer
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The panel's current background works well in average situations, but in high contrast mode I noticed that certain color combinations in the web content can be pretty distracting behind the panel.
Attachment #8778384 -
Flags: review?(mdeboer)
Assignee | ||
Updated•8 years ago
|
Priority: -- → P3
Assignee | ||
Updated•8 years ago
|
Points: 3 → ---
Comment 1•8 years ago
|
||
Comment on attachment 8778384 [details] [diff] [review]
patch
Review of attachment 8778384 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not really aware of the percentage-based rgb notation being commonly used, so I thought you'd take this opportunity to change it to real values.
If possible, can you do that?
Attachment #8778384 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Certainly possible, but for made-up values rather than colors exported from a graphics editor, I prefer percentages over a 255-based scale where I need to start calculating to get my 33% gray tone for instance.
We have no rule for this and use pretty much all available notations all over the place. If we were to create a rule, I'd lobby for HSL and just avoid RGB and HEX notations altogether.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d54bb89e78af
Make Ctrl+Tab panel background more opaque. r=mdeboer
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8778384 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: bug 1116787
[User impact if declined]: see comment 0. bug 1116787 is in the release notes, so this feature will get more attention. would be nice to have it polished.
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: trivial adjustment of a few CSS colors, basically no risk
[String/UUID change made/needed]: none
Attachment #8778384 -
Flags: approval-mozilla-aurora?
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5648449ab916
followup, use hsl instead of rgb color notation
Comment 7•8 years ago
|
||
bugherder |
status-firefox50:
--- → affected
Comment on attachment 8778384 [details] [diff] [review]
patch
CSS only, low risk, Aurora50+
Attachment #8778384 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•