separated from bug 1290637. see bug 1290637 for the details. Required code changes are following: * Check each usage of non-standard Iterator [1] function, and replace it with Object.entries [2] or Object.values [3], or something appropriate for the specific usage Here's the rough list for Iterator() usage (not exhaustive) https://dxr.mozilla.org/comm-central/search?q=%22+Iterator(%22+path%3Asuite%2F&redirect=false for example: for (let [k, v] in Iterator(obj)) { ... } can be replaced to: for (let [k, v] of Object.entries(obj)) { ... } another example: for (let [, v] in Iterator(array)) { ... } can be replaced to: for (let v of array) { ... } [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries [3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values

Hi Tooru! I would like to take this up. Please assign it to me.

Great!

Please have a look at the patch! :)

Comment on attachment 8823331 [details] [diff] [review] BugFix1293008.patch Review of attachment 8823331 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! It's almost there. Please update the patch and post again :) ::: suite/mailnews/tabmail.xml @@ +353,4 @@ > this.setTabTitle(firstTabInfo); > if (this.tabMonitors.length) > { > + for (let [i, tabMonitor] of Object.entries(this.tabMonitors)) (this is pre-existing tho) since `i` is not used and `this.tabMonitors` is an array, you can use `for (let tabMonitor of this.tabMonitors)` here and below 3 places.

This patch should work. Thanks for help. :)

Comment on attachment 8823620 [details] [diff] [review] BugFix1293008.patch Review of attachment 8823620 [details] [diff] [review]: ----------------------------------------------------------------- Thank you again! it looks good. forwarding to IanN.

Comment on attachment 8823620 [details] [diff] [review] BugFix1293008.patch r/a=me Thanks!

Hi Tooru! What do we need to do now? This patch needs to be landed to mozilla code?

thank you for the heads up :) given that the patch got review+ and approval, I'll push the patch to comm-central shortly.

https://hg.mozilla.org/comm-central/rev/2865d0a1c2a217952a6e5315b39835c2849d02b1 Bug 1293008 - Replace in-tree consumer of non-standard Iterator() with Object.{values,entries} in suite/ in comm-central, r=IanN, a=IanN