Alastor Wu [:alwu] Reporter
	Description • 8 years ago

It works when I press the close button, but doesn't work when pressing keyboard shortcut.

STR.
1. make sure the pref "browser.tabs.warnOnCloseOtherTabs" is on
2. open lots tabs
3. close tab with keyboard shortcut (command + Q)

Expected.
4. warn user about "Are you sure to close multiple tabs?"

Actual.
4. close firefox

	Emil Pasca [:emilpasca]
	Comment 1 • 8 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:51.0) Gecko/20100101 Firefox/51

I have tested this issue on Mac OS X 10.10 with the latest Firefox release (48.0) and the latest Nightly (51.0a1-20160811030201) and manage to reproduce it.
After making sure that the pref make sure the pref "browser.tabs.warnOnCloseOtherTabs" is on and opening a a lot of tabs, when using the keyboard shortcut "command + Q", all tabs are closed without showing any warning.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 2 • 8 years ago

(In reply to Emil Pasca [:emilpasca] from comment #1)
> User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:51.0)
> Gecko/20100101 Firefox/51
> 
> I have tested this issue on Mac OS X 10.10 with the latest Firefox release
> (48.0) and the latest Nightly (51.0a1-20160811030201) and manage to
> reproduce it.
> After making sure that the pref make sure the pref
> "browser.tabs.warnOnCloseOtherTabs" is on and opening a a lot of tabs, when
> using the keyboard shortcut "command + Q", all tabs are closed without
> showing any warning.

I cannot reproduce this, either.

Alastor,
Which version are you using?

	Alastor Wu [:alwu] Reporter
	Comment 3 • 8 years ago

Hi, Hsin-yi,
I can reproduce this issue both in latest nightly and FF47. 
It won't show me the warning when I open 20+ tabs and close them by keyboard shortcut "command + Q".

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 4 • 8 years ago

I tried again on Nightly 51.0a1 but closing 70 tabs didn't trigger any warning messages. Going to set P3 due to the rather low reproduce rate.

	Alastor Wu [:alwu] Reporter
	Comment 5 • 8 years ago

Hi, Hsin-yi,
If you don’t see the warning message, that means you have already reproduced the bug ;)
The warning message should be showed to user to avoid suddenly closing multiple tabs.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 6 • 8 years ago

(In reply to Alastor Wu [:alwu] from comment #5)
> Hi, Hsin-yi,
> If you don’t see the warning message, that means you have already reproduced
> the bug ;)
> The warning message should be showed to user to avoid suddenly closing
> multiple tabs.

Yes, I did stupid things (so embarrased:P )
Do you happen to know it's a regression or not?

	Alastor Wu [:alwu] Reporter
	Comment 7 • 8 years ago

I'm not sure whether that is a regression or not.
But I encountered this problem for a long while, it maybe happen from 44 or more early version.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 8 • 8 years ago

(In reply to Alastor Wu [:alwu] from comment #7)
> I'm not sure whether that is a regression or not.
> But I encountered this problem for a long while, it maybe happen from 44 or
> more early version.

Got it, thanks. :)
I just played with FF 45 where the issue exists.

	Alastor Wu [:alwu] Reporter
	Comment 9 • 8 years ago

Hi, Hsin-yi,
Do you know where is the related code? 
Could you help me find it out or transfer the NI to the right person?
I would like to solve this issue.
Thanks :)

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 10 • 8 years ago

(In reply to Alastor Wu [:alwu] from comment #9)
> Hi, Hsin-yi,
> Do you know where is the related code? 
> Could you help me find it out or transfer the NI to the right person?
> I would like to solve this issue.
> Thanks :)

Hi Samael, could you shed some light here? Thanks!

	Samael Wang [:freesamael] (away for now)
	Comment 11 • 8 years ago

So I tried some ancient versions and on macOS the behavior was changed somewhere between Firefox 2.0 and 3.0, so it's been there for many years.

Better to check if it was intended. Maybe it was too annoying when closing multiple windows, or restarting your computer, plus accidental quitting is automatically recovered by session store? It also better fits "Reopen windows when logging in back" feature on macOS.

Just saying but there does exist some reasonable use cases I can think of.

FWIW, the "Close Window" menu item and the close button should both trigger BrowserTryToCloseWindow() [1], while "Quit Firefox" menu item and CMD-Q should be handled by goQuitApplication() [2]. I'm not sure if SIGTERM goes to nsAppStartup::Quit() [3] directly or also handled by goQuitApplication().

[1] http://searchfox.org/mozilla-central/rev/e8dd21b1673c07307068303ab3e99360c78f4d12/browser/base/content/browser.js#2034
[2] http://searchfox.org/mozilla-central/rev/3e03a4064eb585d96f28023785a5c242969878a6/toolkit/content/globalOverlay.js#61
[3] http://searchfox.org/mozilla-central/rev/e8dd21b1673c07307068303ab3e99360c78f4d12/toolkit/components/startup/nsAppStartup.cpp#301

	Andrew Overholt [:overholt]
	Comment 12 • 8 years ago

I think this should maybe be duped to bug 52821. Alastor, WDYT?

	Alastor Wu [:alwu] Reporter
	Comment 13 • 8 years ago

(In reply to Andrew Overholt [:overholt] from comment #12)
> I think this should maybe be duped to bug 52821. Alastor, WDYT?

Yes, thanks for mention that!