Closed Bug 1293370 Opened 8 years ago Closed 8 years ago

Double equal sign (==) in definition of entity conversation.muc.invitationWithReason.password

Categories

(Chat Core :: XMPP, defect)

Product:
Chat Core
Component:
XMPP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird50 fixed, thunderbird51 fixed)

Status:
RESOLVED FIXED
Milestone:
Instantbird 51
Tracking Flags:
Tracking Status
thunderbird50 --- fixed
thunderbird51 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(1 file)

patch, v1
(deleted), patch
aleth
: review+
jorgk-bmo
: approval-comm-aurora+
Details | Diff | Splinter Review
> conversation.muc.invitationWithReason.password==%1$S has invited you to join %2$S with password %3$S: %4$S should be > conversation.muc.invitationWithReason.password=%1$S has invited you to join %2$S with password %3$S: %4$S The initial string landed in bug 1281722.
Comment on attachment 8779021 [details] [diff] [review] patch, v1 Why isn't the 2 on the |messageID += ".password";| line?
> Why isn't the 2 on the |messageID += ".password";| line? Because then the other password entity conversation.muc.invitationWithoutReason.password would need an id change.
Comment on attachment 8779021 [details] [diff] [review] patch, v1 Review of attachment 8779021 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8779021 - Flags: review?(aleth) → review+
Comment on attachment 8779021 [details] [diff] [review] patch, v1 [Approval Request Comment] User impact if declined: Incorrect string, let's get this into aurora quickly.
Attachment #8779021 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/04a0160f5d4d If I just remove one equal sign from the string without changing the ID, would such a fix be okay for Ib 50 (especially if I doesn't get used for a release)? From the locales who already translated this, only Russian has removed the duplicate equal sign: https://transvision.mozfr.org/string/?entity=chat/xmpp.properties:conversation.muc.invitationWithReason.password&repo=aurora
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-thunderbird51: --- → fixed
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 51
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] from comment #6) > https://hg.mozilla.org/comm-central/rev/04a0160f5d4d > > If I just remove one equal sign from the string without changing the ID, > would such a fix be okay for Ib 50 (especially if I doesn't get used for a > release)? From the locales who already translated this, only Russian has > removed the duplicate equal sign: > https://transvision.mozfr.org/string/?entity=chat/xmpp.properties: > conversation.muc.invitationWithReason.password&repo=aurora I suspect it's better to just uplift your patch and then hope the new string gets picked up. Maybe ask on #l10n if it's advisable to ping people about it.
Attachment #8779021 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: