Closed Bug 1293812 Opened 8 years ago Closed 8 years ago

stylo: Use AllChildIterator instead of FlattenedChildIterator during style context fixup

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bholley, Unassigned)

References

Details

This allows us to traverse NAC as well. See bug 1292618 comment 3.
Summary: Use AllChildIterator instead of FlattenedChildIterator during style context fixup → stylo: Use AllChildIterator instead of FlattenedChildIterator during style context fixup
We'll need to make sure we don't double-process any NAC-backed pseudos (::before and ::after, and the HTML5 form control pseudos - pretty much everything except ::first-letter and ::first-line). I wonder how that should work...
I guess during parallel traversal we'll want to expose NAC to Servo, but _only_ NAC that doesn't correspond to a PE (since those are handled by the hashmap). And we'll want to avoid traversing them in the case that the change hint is ReconstructFrame, since that'd be wasted work. Then, during SC fixup, we can just use AllChildrenIterator. For PE NAC, we use the style from the hashmap. For Non-PE NAC, we use the style that parallel traversal cached on the NodeData.
Blocks: 1292662
This was fixed with incremental restyle.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.