Closed
Bug 1293840
Opened 8 years ago
Closed 8 years ago
Check that HAVE_64_BIT_BUILD result matches what we know of the target platform
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We've had the HAVE_64_BIT_BUILD check forever, but we've never actually bothered checking its result matches our expectations considering the target CPU.
|
Assignee | |
Comment 1•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #0)
> We've had the HAVE_64_BIT_BUILD check forever, but we've never actually
> bothered checking its result matches our expectations considering the target
> CPU.
Moreover, we have some things that use the value of HAVE_64BIT_BUILD even on artifact builds, but artifact builds don't run the test, so the value is wrong on 64-bits artifact builds. This bug should fix this at the same time.
Assignee: nobody → mh+mozilla
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8779600 [details]
Bug 1293840 - Determine HAVE_64BIT_BUILD from --target.
https://reviewboard.mozilla.org/r/70550/#review68092
Attachment #8779600 -
Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/f6a8a2c61740
Determine HAVE_64BIT_BUILD from --target. r=chmanchester
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•