Closed
Bug 1294435
Opened 8 years ago
Closed 8 years ago
The control center panel flickers when shrinking after removing a permission item
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 51
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | verified |
People
(Reporter: florian, Assigned: florian)
References
Details
(Keywords: regression, Whiteboard: [fxprivacy])
This is a consequence of the hack introduced in bug 1280709.
Bug 1206233 makes this more noticeable as when clicking on the 'X' icon of the camera or microphone row, both streams get stopped at once, causing the panel to flicker twice.
See the discussion from bug 1206233 comment 18 to bug 1206233 comment 36.
Comment 1•8 years ago
|
||
We also have several cases where the need for calling setHeightToFit() causes issues in the Downloads Panel because there are cases where the structure of the panel changes because of update events on individual downloads. Instrumenting these cases with setHeightToFit() might cause more flickering there as well.
We should probably define a special class on the <spacer> above the footer, and have the <panelmultiview> machinery look for this element on the main view. The flex attribute on this element would be set to "1" only while opening a subview, and its height or flex attribute would be reset to "0" when the main view is restored, after the animation is finished.
Bonus points if we can fix the existing bug in the main menu for which the main view shrinks immediately instead of following the smooth animation of the panel and the subview.
Comment 2•8 years ago
|
||
[Tracking Requested - why for this release]:
Bug 1280709 fixed the footer button issue, but introduced other height calculation issues for the Downloads Panel.
tracking-firefox50:
--- → ?
Updated•8 years ago
|
Comment 3•8 years ago
|
||
Hopefully bug 1293242 will fix this, but we should at least retest after that one is fixed.
Depends on: 1293242
Comment 4•8 years ago
|
||
In https://bugzilla.mozilla.org/show_bug.cgi?id=1206233#c48 I granted r+ to this patch. I don't think any changes need to be made to the patch and it applied fine for me on d33489bb8862.
Panos, since Florian is on PTO until August 29th, do you want to make the call here about landing this?
Flags: needinfo?(past)
Comment 6•8 years ago
|
||
The last patch from bug 1206233 has fixed this for me.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
tracking-firefox50:
? → ---
Updated•8 years ago
|
Priority: P2 → --
Whiteboard: [fxprivacy] → [fxprivacy][triage]
Comment 8•8 years ago
|
||
[Triage] QE-Verify + to confirm behavior.
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Comment 9•8 years ago
|
||
Verified fixed FX 51.0a1 (2016-08-23) Win 7, Ubuntu 14.04, OS X 10.12
Status: RESOLVED → VERIFIED
status-firefox51:
--- → verified
Updated•8 years ago
|
Assignee: nobody → florian
status-firefox50:
--- → unaffected
Target Milestone: --- → Firefox 51
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•