Closed
Bug 1294549
Opened 8 years ago
Closed 8 years ago
nestegg: division by zero in [@nestegg_duration] nestegg.c:2080
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | affected |
People
(Reporter: tsmith, Assigned: kinetik)
References
Details
(Keywords: testcase)
Attachments
(1 file)
|
(deleted),
video/webm
|
Details |
I found this while fuzzing nestegg commit 4d261a4df28fc193ffa9360bffdb3dbe9947a44c
Run the attached test case in a Undefined Behavior Sanitizer (UBSan) build to trigger the following error:
src/nestegg.c:2080:74: runtime error: division by zero
#0 0x4f2913 in nestegg_duration /srv/jenkins/jobs/nestegg/workspace/default/src/nestegg.c:2080:74
#1 0x4ea228 in main /srv/jenkins/jobs/nestegg/workspace/default/test/test.c:112:7
#2 0x7f24d65fb82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#3 0x4188c8 in _start (/home/ubuntu/build/build/test+0x4188c8)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → kinetik
|
|
Assignee | |
Comment 1•8 years ago
|
||
Thanks. Looks like we need to treat a timecode scale of 0 as an error.
I attached a fix in bug 1294527 as part of the fix for that bug.
|
Reporter | |
Comment 2•8 years ago
|
||
Verified fixed with nestegg revision 9b7b79412432df3c3f996b42eac19ce60d56ee48. Thanks!
|
||
Updated•8 years ago
|
Priority: -- → P1
|
||
Comment 3•8 years ago
|
||
Can we get the fix landed and close this bug? Thanks.
Flags: needinfo?(kinetik)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Fixed by bug 1296988.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(kinetik)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•