‘New Window’ and ‘New Private Window’ options disappear from macOS dock context menu when switching to non-tabbrowser top-level window
Categories
(Firefox :: Menus, defect)
Tracking
()
People
(Reporter: gen-mozilla, Assigned: KWierso)
References
Details
(Keywords: regression, Whiteboard: tpi:-)
Attachments
(2 files)
(deleted),
video/quicktime
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta-
|
Details |
Comment 3•8 years ago
|
||
Updated•8 years ago
|
Comment 10•8 years ago
|
||
Comment 11•8 years ago
|
||
Comment 12•8 years ago
|
||
Reporter | ||
Comment 13•8 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 19•7 years ago
|
||
Comment 22•7 years ago
|
||
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Updated•7 years ago
|
Comment 26•7 years ago
|
||
Updated•7 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 27•6 years ago
|
||
Assignee | ||
Comment 28•6 years ago
|
||
Assignee | ||
Comment 29•6 years ago
|
||
Assignee | ||
Comment 30•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 31•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 32•6 years ago
|
||
Comment on attachment 9034071 [details]
Bug 1294933 - Only release the reference to the mac dockmenu when the hidden window is shutdown r?peterv
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1262110
User impact if declined: The options in the Firefox icon's context menu in the OSX dock to open new windows and new private windows disappear after closing any non-browser window. This has been broken since bug 1262110 landed three years ago for Firefox 48, so this isn't a recent regression, but it would be nice to get this fixed sooner for users, as there have been a number of duplicate bugs filed over the last few years.
Is this code covered by automated tests?: Unknown
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: Yes
If yes, steps to reproduce: I checked the build from the push where this initially landed and the fix works for me. I guess it wouldn't hurt for QA to verify this.
Steps:
- Install and run a build with this patch applied on OSX.
- Right-click the Firefox icon for that running build of Firefox in the dock.
- See the "New Window" and "New Private Window" options in the menu.
- Open the build's 'About Firefox' window (via the main menu > "Firefox Nightly" (or, once uplifted, "Firefox" or "Firefox Developer Edition") > "About Firefox".
- Close the About window.
- Right-click the dock icon again.
If the patch works, the "New Window" and "New Private Window" options will still be there.
If the patch didn't work, those options will no longer be listed.
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): There's a slight risk that this might reintroduce the shutdown leak that bug 1262110 had initially fixed by releasing the reference to the dockmenu items when non-browser windows were closed. The reference is still released with this new patch, but only when the final hidden window is being closed. In theory this shouldn't leak anything on shutdown, since the reference is still released before everything shuts down (and no automated tests have shown a leak since this patch landed), but I guess there's still a chance it could happen.
String changes made/needed:
Comment 33•6 years ago
|
||
bugherder |
Comment 34•6 years ago
|
||
Updated•6 years ago
|
Comment 35•6 years ago
|
||
Comment on attachment 9034071 [details]
Bug 1294933 - Only release the reference to the mac dockmenu when the hidden window is shutdown r?peterv
[Triage Comment]
We've been living with this for 2 years now, so I think this can just ride the trains. Will give us more time to suss out any possible leak regressions from it too.
Updated•6 years ago
|
Comment 36•6 years ago
|
||
Comment on attachment 9034071 [details]
Bug 1294933 - Only release the reference to the mac dockmenu when the hidden window is shutdown r?peterv
Whoops.
Comment 37•6 years ago
|
||
Sorry for not having read through the whole thread.
Since this was just marked "wontfix", is there a suggested workaround?
I think simply uninstalling Firefox and never selecting "About Firefox" again should do the trick. I'll have to find a different way to determine what version of FF I'm on, but that's a small price to pay for being able to create new windows from the dock.
Comment 38•6 years ago
|
||
Nevermind! Looks like this fix will be in FF 66. Thanks Wes Kocher.
Reporter | ||
Comment 39•6 years ago
|
||
In Firefox Developer Edition 66.0b2 on mac OS 10.14, I'm confirming that the dock icon menu items for New Window and New Private Window are now remaining visible and available, even after opening History, Bookmarks and About.
Thanks everyone.
Comment 40•6 years ago
|
||
Can confirm the issue exists in 65.0 with the following specs:
Version 65.0
Build ID 20190124174741
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:65.0) Gecko/20100101 Firefox/65.0
Can also verify it's working in 66.0 with the following specs:
Version 66.0b3
Build ID 20190128143734
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:66.0) Gecko/20100101 Firefox/66.0
Description
•