Closed
Bug 1294983
Opened 8 years ago
Closed 8 years ago
Invalid CSS variable usage for .panel-arrow from bug 1293099
Categories
(WebExtensions :: Frontend, defect)
WebExtensions
Frontend
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jaws, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
The patch that landed in bug 1293099 has lines like:
> list-style-image: var(--panel-arrow-image-vertical,
> url("chrome://global/skin/arrow/panelarrow-vertical-themed.svg"));
This however is invalid syntax, though Gecko doesn't complain. I will file a separate bug for that.
This should be:
> list-style-image: var(--panel-arrow-image-vertical),
> url("chrome://global/skin/arrow/panelarrow-vertical-themed.svg");
In the incorrect example, only the CSS variable value will be applied. In the second example both will be applied.
Tested with the attached file.
Flags: needinfo?(kmaglione+bmo)
Reporter | ||
Comment 1•8 years ago
|
||
Filed bug 1294984 for the Gecko bug.
Comment 2•8 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #0)
> Created attachment 8780851 [details]
> cssvar.html
>
> The patch that landed in bug 1293099 has lines like:
>
> > list-style-image: var(--panel-arrow-image-vertical,
> > url("chrome://global/skin/arrow/panelarrow-vertical-themed.svg"));
>
> This however is invalid syntax, though Gecko doesn't complain. I will file a
> separate bug for that.
It's not invalid syntax. The variable is used if it's defined, otherwise the
URL is used.
> This should be:
>
> > list-style-image: var(--panel-arrow-image-vertical),
> > url("chrome://global/skin/arrow/panelarrow-vertical-themed.svg");
>
> In the incorrect example, only the CSS variable value will be applied. In
> the second example both will be applied.
That produces an error when the variable isn't defined, which by default, it's
not.
Updated•8 years ago
|
Flags: needinfo?(kmaglione+bmo)
Comment 3•8 years ago
|
||
Closing as invalid since this is completely valid syntax and works as expected. Please reopen if you have other issues.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•