Closed
Bug 1295541
Opened 8 years ago
Closed 8 years ago
Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder()
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox48 | --- | unaffected |
firefox49 | --- | unaffected |
firefox50 | --- | unaffected |
firefox51 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
(Keywords: regression)
Attachments
(1 file)
When we shut down a decoder, we should always disconnect the init promise. Hope this will fix bug 1295146.
https://hg.mozilla.org/mozilla-central/file/054d4856cea6150a6638e5daf7913713281af97d/dom/media/MediaFormatReader.cpp#l2119
Note SetVideoBlankDecode() shuts down the decoder without disconnect the init promise which might be the cause of bug 1295146.
Assignee | ||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8781519 -
Flags: review?(jyavenard)
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8781519 [details]
Bug 1295541 - Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder().
https://reviewboard.mozilla.org/r/71930/#review69602
Attachment #8781519 -
Flags: review?(jyavenard) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c239558f86a3
Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder(). r=jya
Updated•8 years ago
|
status-firefox48:
--- → unaffected
status-firefox49:
--- → unaffected
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•8 years ago
|
Updated•8 years ago
|
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•