Closed
Bug 1295769
Opened 8 years ago
Closed 8 years ago
Zoom indicator zoom effect could be smoother
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 51
Tracking | Status | |
---|---|---|
firefox51 | --- | verified |
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
Bug 565718 added a zoom indicator to the URL bar. The first time it's shown, the indicator has a little animation to draw attention to it:
@keyframes urlbar-zoom-reset-pulse {
0% {
transform: scale(0);
}
100% {
transform: scale(1.5);
}
}
This feels a bit jarring to me, because at the end of the animation it snaps back to 100% instantly. Seems like this would be a little bit smoother if it was more of a "bounce".
Assignee | ||
Updated•8 years ago
|
QA Contact: dolske
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
. o O (how do I always manage to click "take" next to QA Contact instead of assignee?)
IIRC the fancy-pants way to do this is with "animation-timing-function: cubic-bezier(mumble)", but I'm not sure if that works with @keyframes and this is pretty dead-simple.
Assignee: nobody → dolske
QA Contact: dolske
Comment 3•8 years ago
|
||
The mockup I did was more of a pulse than a grow: http://people.mozilla.org/~shorlander/mockups-interactive/firefox-ui/zoom-indicator-osx-yosemite.html
Also avoids scaling the text (which seems pretty jaggy)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8781738 [details]
Bug 1295769 - Zoom indicator zoom effect could be smoother.
https://reviewboard.mozilla.org/r/72088/#review69868
Attachment #8781738 -
Flags: review?(kbroida) → review+
Pushed by jdolske@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0efbd7c33fe
Zoom indicator zoom effect could be smoother. r=ktbee
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Updated•8 years ago
|
Flags: qe-verify+
Comment 7•8 years ago
|
||
Verified as fixed using Firefox 51 beta 1 under Win 10 64-bit and Mac OS X 10.12. The animation is slightly smoother.
You need to log in
before you can comment on or make changes to this bug.
Description
•