Closed Bug 1296146 Opened 8 years ago Closed 8 years ago

Gradle toplevel directory conflicts with gradle tooltool extract

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Unassigned)

References

Details

So while working locally on android single locale TC support, I hit some issues with letting the source update to the m-c's nightly changeset... This turned out to be due to missing `^gradle/**` files, of which there are exactly 2. Upon further inspection of the log, on my TC run (and then on a m-c run) I saw during the tooltool step 20:57:03 INFO - INFO - rm tree: gradle 20:57:03 INFO - INFO - untarring "gradle.tar.xz" (( https://archive.mozilla.org/pub/mobile/tinderbox-builds/mozilla-central-l10n/mozilla-central-android-api-15-l10n_3-unknown-bm72-build1-build3.txt.gz )) This rm is tooltool cleaning up the destination folder for 'gradle' itself. We should either move where gradle extracts to or move that topsrcdir folder. I don't know enough about the implications/code-changes-needed for either option though. :sebastian, ideas (since nick is away for another ~ 10 days)
Flags: needinfo?(s.kaspari)
Clearing NI: We talked on IRC and I filed bug 1296146.
Flags: needinfo?(s.kaspari)
(In reply to Sebastian Kaspari (:sebastian) from comment #1) > Clearing NI: We talked on IRC and I filed bug 1296146. This should be bug 1296335.
(In reply to Sebastian Kaspari (:sebastian) from comment #2) > (In reply to Sebastian Kaspari (:sebastian) from comment #1) > > Clearing NI: We talked on IRC and I filed bug 1296146. > > This should be bug 1296335. Why file a separate bug? That bug is addressing exactly what's being described here. IOW, you just filed what looks like a dupe.
Just in case Justin needs to add any follow-up patches here.
Justin: The patches just landed in mozilla-central. Is anything else required? If you need to pull the new archive from tooltool, here are the new values: https://hg.mozilla.org/integration/autoland/rev/30b037e0fd1d
Flags: needinfo?(bugspam.Callek)
I think this is all I need (I'm PTO this week, so will verify when I'm back next week -- forgot to block n-i)
Flags: needinfo?(bugspam.Callek)
Blocks: 1300813
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Product: Firefox for Android → Firefox Build System
You need to log in before you can comment on or make changes to this bug.