Andi [:andi] Assignee
	Description • 8 years ago

The Static Analysis tool Coverity detected that pointer |options| is not freed after it looses it's scope.

In the following code |options| gets allocated:

>>      cairo_font_options_t *options = cairo_font_options_create();
>>      cairo_scaled_font_get_font_options(mScaledFont, options);
>>
>>      if (cairo_font_options_get_antialias(options) != CAIRO_ANTIALIAS_NONE) {
>>        if (cairo_scaled_font_get_type(mScaledFont) == CAIRO_FONT_TYPE_WIN32) {

After that no where till the end of it's scot it isn't cached so loosing it's scope it will leak memory.

	Jonathan Kew [:jfkthame]
	Comment 2 • 8 years ago

Just FTR, it looks like this was introduced in bug 943626, which just landed for mozilla-51, so it doesn't affect existing releases.

	Jeff Muizelaar [:jrmuizel]
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8782407 [details]
Bug 1296258 - prevent memory leak in ScaledFontBase::GetGlyphDesignMetrics.

https://reviewboard.mozilla.org/r/72596/#review71208

	Pulsebot
	Comment 4 • 8 years ago

Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3748b7a5ea35
prevent memory leak in ScaledFontBase::GetGlyphDesignMetrics. r=jrmuizel

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3748b7a5ea35