Bas Schouten (:bas.schouten) Assignee
	Description • 8 years ago

It's better if it does care.

	Jeff Muizelaar [:jrmuizel]
	Comment 2 • 8 years ago

Comment on attachment 8782946 [details]
Bug 1296657: Attempt to create an mOptSurface of the correct type for the DT we're drawing to.

Seth's been looking at this code lately so might as well have him look too.

	Timothy Nikkel (:tnikkel)
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8782946 [details]
Bug 1296657: Attempt to create an mOptSurface of the correct type for the DT we're drawing to.

https://reviewboard.mozilla.org/r/72948/#review71248

Seems reasonable. feedback+. I think Seth has been changing this lately so he might know of any additional constraints. If he doesn't get back to you in a reasonable time I can take a closer look.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 4 • 8 years ago

Timothy, do you think you can review this?

	Timothy Nikkel (:tnikkel)
	Comment 5 • 8 years ago
mozreview-review

Comment on attachment 8782946 [details]
Bug 1296657: Attempt to create an mOptSurface of the correct type for the DT we're drawing to.

https://reviewboard.mozilla.org/r/72948/#review75658

	Jeff Muizelaar [:jrmuizel]
	Comment 6 • 8 years ago
mozreview-review

Comment on attachment 8782946 [details]
Bug 1296657: Attempt to create an mOptSurface of the correct type for the DT we're drawing to.

https://reviewboard.mozilla.org/r/72948/#review76768

::: image/imgFrame.cpp:399
(Diff revision 1)
>  nsresult
> -imgFrame::Optimize()
> +imgFrame::Optimize(DrawTarget* aTarget)
>  {
>    MOZ_ASSERT(NS_IsMainThread());
>    mMonitor.AssertCurrentThreadOwns();
> -  MOZ_ASSERT(mLockCount == 1,
> +  

Why this change?

	Bas Schouten (:bas.schouten) Assignee
	Comment 7 • 8 years ago

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)
> Comment on attachment 8782946 [details]
> Bug 1296657: Attempt to create an mOptSurface of the correct type for the DT
> we're drawing to.
> 
> https://reviewboard.mozilla.org/r/72948/#review76768
> 
> ::: image/imgFrame.cpp:399
> (Diff revision 1)
> >  nsresult
> > -imgFrame::Optimize()
> > +imgFrame::Optimize(DrawTarget* aTarget)
> >  {
> >    MOZ_ASSERT(NS_IsMainThread());
> >    mMonitor.AssertCurrentThreadOwns();
> > -  MOZ_ASSERT(mLockCount == 1,
> > +  
> 
> Why this change?

Because we no longer call it in the stage where we are holding the lock.

	Pulsebot
	Comment 8 • 8 years ago

Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d378a118900
Attempt to create an mOptSurface of the correct type for the DT we're drawing to. r=tnikkel

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3d378a118900