Closed Bug 1296665 Opened 8 years ago Closed 8 years ago

gfxBlur doesn't care enough about what it's drawing to

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

References

Details

Attachments

(1 file)

Bug 1296665: gfxBlur should attempt to create a box shadow for the correct type of DrawTarget.
(deleted), text/x-review-board-request
mchang
: review+
Details 
It should care more.
Comment on attachment 8782949 [details]
Bug 1296665: gfxBlur should attempt to create a box shadow for the correct type of DrawTarget.

https://reviewboard.mozilla.org/r/72960/#review70716

LGTM. Thanks!
Comment on attachment 8782949 [details]
Bug 1296665: gfxBlur should attempt to create a box shadow for the correct type of DrawTarget.

https://reviewboard.mozilla.org/r/72960/#review70718
Attachment #8782949 - Flags: review?(mchang) → review+
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b071166a07bc
gfxBlur should attempt to create a box shadow for the correct type of DrawTarget. r=mchang
https://hg.mozilla.org/mozilla-central/rev/b071166a07bc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1303434
Reopening, since this was backed out.

Per discussion in #gfx just now, let's maybe wait a few days until after Aurora 51 has branched off of central before we re-landing this (even if we've updated the patch to not cause bug 1303434), to be on the safe side.

(I assume there's no pressing need for this to ship sooner rather than later.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla51 → ---
Testcase for bug 1303434:
data:text/html,<body style="background:linear-gradient(white,white) fixed"><div style="width: 100px; height:20px; box-shadow: 0 1px 3px rgba(0, 0, 0, 0.4);">Test</div>

This happens when painting into a component alpha layer / DrawTargetDual. Is aDestDT.CreateSimilarDrawTarget creating a DrawTargetDual?
(In reply to Markus Stange [:mstange] from comment #8)
> Testcase for bug 1303434:
> data:text/html,<body style="background:linear-gradient(white,white)
> fixed"><div style="width: 100px; height:20px; box-shadow: 0 1px 3px rgba(0,
> 0, 0, 0.4);">Test</div>
> 
> This happens when painting into a component alpha layer / DrawTargetDual. Is
> aDestDT.CreateSimilarDrawTarget creating a DrawTargetDual?

I bet it is, I'll have a look at this, thanks for investigating.

(In reply to Daniel Holbert [:dholbert] from comment #7)
> Reopening, since this was backed out.
> 
> Per discussion in #gfx just now, let's maybe wait a few days until after
> Aurora 51 has branched off of central before we re-landing this (even if
> we've updated the patch to not cause bug 1303434), to be on the safe side.
> 
> (I assume there's no pressing need for this to ship sooner rather than later.

Performance in some pop-up windows might be slightly regressed by this.
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9acf38c9f720
gfxBlur should attempt to create a box shadow for the correct type of DrawTarget. r=mchang
https://hg.mozilla.org/mozilla-central/rev/9acf38c9f720
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: