Since bug 1272401 got fixed if you load or reload a new tab the loading throbber will no longer display if a favicon is already shown in the tab. The image attribute needs to be removed from the tab while busy for this to work. This was removed in above bug.

Comment on attachment 8783179 [details] [diff] [review] 1296838-loadingthrobber.patch That doesn't work properly for me on Linux (KDE4/GTK3). Yes, the throbber on the respective tab shows up again even if the current tab has a favicon set, then also sets the new favicon once done, but then it is immediately replaced with the generic icon for a page without favicon. suite/themes/classic/communicator/bookmarks/bookmark-item.png Thus, it looks like this.mTab.removeAttribute("image"); is also executed when the page has completed loading, then removing the favicon again which was just set elsewhere.

I finally got CentOS compiling and running right yesterday. I will look into it during the weekend. Patch for Bug 1296850 isn't meant as a dependency for this one. Is aggressively look for website icons checked in your profile? FRG

(In reply to rsx11m from comment #2) > That doesn't work properly for me on Linux (KDE4/GTK3). > > Yes, the throbber on the respective tab shows up again even if the current > tab has a favicon set, then also sets the new favicon once done, but then it > is immediately replaced with the generic icon for a page without favicon. @rsx11m: What website(s) do you see this happen on? I did a test build with this patch (SeaMonkey 2.46 linux64 w/ gtk2), and I cannot reproduce that behavior except at http://html5test.com/ All other sites I've browsed, the favicon sticks..

(In reply to Frank-Rainer Grahl from comment #3) > Is aggressively look for website icons checked in your profile? New profile = box is unchecked. (In reply to kevink9876543 from comment #4) > @rsx11m: What website(s) do you see this happen on? I did a test build with > this patch (SeaMonkey 2.46 linux64 w/ gtk2), and I cannot reproduce that Something as simple as https://bugzilla.mozilla.org/ I'm using SeaMonkey 2.48a1 linux64 w/ gtk3. ^^^^ ^

(In reply to rsx11m from comment #5) > Something as simple as https://bugzilla.mozilla.org/ > > I'm using SeaMonkey 2.48a1 linux64 w/ gtk3. I put the change in the omni.ja of this official build https://ftp.mozilla.org/pub/seamonkey/nightly/2016/08/2016-08-18-00-30-02-comm-central-trunk/ , still get the same results there.

No clue what's going on (that's my own build, but I don't think I've mangled any other patches into it which may interfere), let's wait for frg if he can reproduce it.

I can reproduce it on html5test.com under Windows if I enable scripts for whichbrowser.net. Something funky going on here. Need to try 2.44 and Firefox to see if this is also the case there. Will try Linux later when I am back on the desktop.

This should finally work. Tested on html5test.com and bugzilla.

Comment on attachment 8785625 [details] [diff] [review] 1296838-loadingthrobber-V2.patch r=me a=me please land on all branches a=me

https://hg.mozilla.org/comm-central/rev/f33e19bca589 https://hg.mozilla.org/releases/comm-aurora/rev/607e74f5fb39 https://hg.mozilla.org/releases/comm-beta/rev/1464e26a9aa5 https://hg.mozilla.org/releases/comm-release/rev/51994306d373