Closed Bug 1296896 Opened 8 years ago Closed 3 years ago

Content script's async methods may return a promise for chrome.* methods because chrome===browser

Categories

(WebExtensions :: General, defect, P5)

Product:
WebExtensions
Component:
General
Version:
51 Branch
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: robwu, Assigned: robwu)

References

Details

(Whiteboard: triaged) 

Content process:
- ChildAPIManager
http://searchfox.org/mozilla-central/rev/f433f0dd7158d7bfc4c4607161fc6baa88b5a9f4/toolkit/components/extensions/ExtensionUtils.jsm#1482
- API injection http://searchfox.org/mozilla-central/rev/f433f0dd7158d7bfc4c4607161fc6baa88b5a9f4/toolkit/components/extensions/ExtensionContent.jsm#406

Browser process: 
- wrapper http://searchfox.org/mozilla-central/rev/f433f0dd7158d7bfc4c4607161fc6baa88b5a9f4/toolkit/components/extensions/Extension.jsm#669
- API injection http://searchfox.org/mozilla-central/rev/f433f0dd7158d7bfc4c4607161fc6baa88b5a9f4/toolkit/components/extensions/Extension.jsm#726 (browser !== chrome)

This bug is currently limited to schema-generated content script APIs. Currently only chrome.storage is affected since it's the only schema-generated content script API; when bug 287010 is fixed some more APIs are affected, and when bug 1287007 is fixed many addon APIs are affected.
Whiteboard: triaged
The first bug number is missing a "1" - it should be bug 1287010.

chrome.runtime.sendMessage is also affected by this bug.
When I fix this bug, I should not forget to update http://searchfox.org/mozilla-central/rev/8eb4fd2c7be150b0aa1b05c0f3707e82dc8f2dc8/toolkit/components/extensions/test/mochitest/test_ext_sendmessage_no_receiver.html#58 (from bug 1295473).
Priority: -- → P5
Product: Toolkit → WebExtensions
Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958
status-firefox51: affected → ---
Component: Untriaged → General

This behavior that was previously classified as a bug is now intentional, see bug 1711570.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1711570
You need to log in before you can comment on or make changes to this bug.