Closed Bug 1296912 Opened 8 years ago Closed 8 years ago

[CSS Grid Highlighter] Canvas size is wrong when zooming in and out

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file)

1296912.patch
(deleted), patch
pbro
: review+
Details | Diff | Splinter Review
The canvas size doesn't seem to behave correctly when zooming in and out. bgrins and I debugged this and determined this is caused by the fact that width and height is not set correctly when it is cleared because of the amount of floating point digits. To solve this, we should try to fix the format the ratio to 2 decimal places.
Attached patch 1296912.patch (deleted) — — Splinter Review
Attachment #8783278 - Flags: review?(pbrosset)
Depends on: 1282726
Attachment #8783278 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/integration/fx-team/rev/cba664ef3a3ea8702508239b463fc8014bbb228b Bug 1296912 - Fix the CSS grid highlighter size when zooming in and out by limiting the devicePixelRatio to 2 decimal places r=pbro
https://hg.mozilla.org/mozilla-central/rev/cba664ef3a3e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: