Closed
Bug 1297039
Opened 8 years ago
Closed 8 years ago
Implement the preference for showing dropmarker or not in Downloads Panel
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
VERIFIED
FIXED
Firefox 51
Tracking | Status | |
---|---|---|
firefox51 | --- | verified |
People
(Reporter: selee, Assigned: selee)
References
Details
(Whiteboard: [CHE-MVP])
Attachments
(1 file)
Since bug 1269962 is in landing process, the preference for showing dropmarker is strongly recommended.
Assignee | ||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → selee
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,
Hey Paolo, as we discussed in bug 1269962 comment 89, could you help to review the patch for a new preference for showing the dropmarker?
Thank you.
Attachment #8783481 -
Flags: review?(paolo.mozmail)
Comment 3•8 years ago
|
||
Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,
Take a look at <https://reviewboard.mozilla.org/r/67412/diff/1#0> for a simpler way to check the preference. You can check the new DownloadsCommon getter when the Downloads Panel is opened. Unfortunately we cannot keep the "panel." namespace, but a preference name like "showPanelDropmarker" could work.
The class approach looks good, just use ".downloadsHideDropmarker" as it puts the namespace first, and "hide" is more correct than "disable" for the CSS class.
Attachment #8783481 -
Flags: review?(paolo.mozmail)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,
Hey Paolo, could you help to review the patch in the second round? Thank you.
Attachment #8783481 -
Flags: review?(paolo.mozmail)
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,
https://reviewboard.mozilla.org/r/73264/#review71372
Looks good! r+ with the change below.
::: browser/app/profile/firefox.js:331
(Diff revision 2)
> pref("browser.download.useDownloadDir", true);
> pref("browser.download.folderList", 1);
> pref("browser.download.manager.addToRecentDocs", true);
> pref("browser.download.manager.resumeOnWakeDelay", 10000);
>
> +pref("browser.download.showPanelDropmarker", true);
Since we will ship this feature only when all the development is complete, you can use this technique to limit this to Nightly and Developer Edition until we give the feature the green light:
https://dxr.mozilla.org/mozilla-central/rev/24763f58772d45279a935790f732d80851924b46/browser/app/profile/firefox.js#1214-1218
This way we are safe from shipping an incomplete feature accidentally, and it's clearer to others that the feature is not finished yet. We'll remove the safeguard when the rest is ready.
Attachment #8783481 -
Flags: review?(paolo.mozmail) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c4f6eb3d1fd8
Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment 10•8 years ago
|
||
verified as fixed in Nightly 51.0a1 /20160913080508 .
Status: RESOLVED → VERIFIED
Comment 11•8 years ago
|
||
Updating flags based on Comment 10.
You need to log in
before you can comment on or make changes to this bug.
Description
•