Closed Bug 1297116 Opened 8 years ago Closed 6 years ago

Investigate removal of editMenuOverlay.xul from toolbox.xul

Categories

(DevTools :: Framework, defect, P3)

46 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bgrins, Unassigned)

References

Details

(Whiteboard: [reserve-html])

The edit menu overlay pulls in some markup into toolbox.xul: <?xul-overlay href="chrome://global/content/editMenuOverlay.xul"?> <!ENTITY % editMenuStrings SYSTEM "chrome://global/locale/editMenuOverlay.dtd"> %editMenuStrings; <commandset id="editMenuCommands"/> <keyset id="editMenuKeys"/> This is used to inject the cut/copy/paste menu items into menus within the toolbox: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Tutorial/Overlays. We need to investigate if that's needed in this top level document and if so, how to remove it. For most text boxes we shouldn't need to do anything. If we want a custom context menu item alongside the normal edit items, then we'll need to come up with a solution using the Menu API and exporting the edit menu as a set of MenuItems.
Flags: qe-verify?
Priority: P2 → P1
Flags: qe-verify? → qe-verify-
Priority: P1 → P2
Priority: P2 → P3
Whiteboard: [devtools-html] → [reserve-html]
Product: Firefox → DevTools

Brian, this has been fixed already, correct?

Honza

Flags: needinfo?(bgrinstead)

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #1)

Brian, this has been fixed already, correct?

Yep, closing.

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(bgrinstead)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.