Closed
Bug 1297132
Opened 8 years ago
Closed 4 years ago
Investigate removal of globalOverlay.js / goUpdateCommand from toolbox
Categories
(DevTools :: Framework, defect, P3)
Tracking
(firefox85 fixed)
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: bgrins, Assigned: jdescottes)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
toolbox.xul loads globalOverlay.js, and then toolbox.js calls goUpdateCommand from _updateTextboxMenuItems. The toolbox's textboxContextMenuPopup variable is used from various tools in the inspector to open a context menu programmatically on elements.
We should investigate if this whole machinery can be removed and just allow a normal context menu popup to open on the text boxes instead: https://dxr.mozilla.org/mozilla-central/search?q=textboxContextMenuPopup&redirect=true.
|
||
Updated•8 years ago
|
Flags: qe-verify?
|
Reporter | |
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
|
|
||
Updated•8 years ago
|
Priority: P2 → P1
|
|
||
Updated•8 years ago
|
Priority: P1 → P2
|
|
||
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [devtools-html] → [reserve-html]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
||
Comment 1•6 years ago
|
||
Brian, this has been fixed already, correct?
Honza
Flags: needinfo?(bgrinstead)
|
|
Reporter | |
Comment 2•6 years ago
|
||
We have goUpdateCommand at https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/devtools/client/framework/toolbox.js#3092 / https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.xul#25-26.
Looking closer though, I actually think this is unused and can be rmeoved ever since we switched to the Menu API for textboxes: https://searchfox.org/mozilla-central/search?q=_updateTextBoxMenuItems&path=.
Flags: needinfo?(bgrinstead)
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bafa6a8f9e76
[devtools] Stop loading unused globalOverlay.js in toolbox r=rcaliman,bgrins
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•