Closed Bug 1297379 Opened 8 years ago Closed 8 years ago

Port Bug 1294650 Block Websense Endpoint by providing a dummy DLL

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.44 wontfix, seamonkey2.45 fixed, seamonkey2.46 fixed, seamonkey2.47 fixed, seamonkey2.48 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
seamonkey2.44 --- wontfix
seamonkey2.45 --- fixed
seamonkey2.46 --- fixed
seamonkey2.47 --- fixed
seamonkey2.48 --- fixed

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

1297379-websense.patch
(deleted), patch
philip.chee
: review+
philip.chee
: approval-comm-aurora+
philip.chee
: approval-comm-beta+
iannbugzilla
: approval-comm-release+
Details | Diff | Splinter Review
1297379-websense-backout.patch
(deleted), patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-aurora+
iannbugzilla
: approval-comm-beta+
iannbugzilla
: approval-comm-release+
Details | Diff | Splinter Review
Bug 1294650 might affect Seamonkey too so copy the shim 'qipcap' dll also into the Seamonkey folder during installation.
Attached patch 1297379-websense.patch (deleted) — — Splinter Review
Attachment #8783958 - Flags: review?(philip.chee)
Comment on attachment 8783958 [details] [diff] [review] 1297379-websense.patch r=me a=me
Attachment #8783958 - Flags: review?(philip.chee) → review+
Leaving open for branches. I think the original bug will get pushed to all fo them.
status-seamonkey2.48: affected → fixed
Whiteboard: [leave open for branches]
Comment on attachment 8783958 [details] [diff] [review] 1297379-websense.patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: Seamonkey might crash if Websense is installed. Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): none. Its just a dummy dll. String changes made by this patch: none
Attachment #8783958 - Flags: approval-comm-beta?
Attachment #8783958 - Flags: approval-comm-aurora?
Attachment #8783958 - Flags: approval-comm-beta?
Attachment #8783958 - Flags: approval-comm-beta+
Attachment #8783958 - Flags: approval-comm-aurora?
Attachment #8783958 - Flags: approval-comm-aurora+
Comment on attachment 8783958 [details] [diff] [review] 1297379-websense.patch [Approval Request Comment] Has now been pushed to c-r also. See comment 5 for information.
Attachment #8783958 - Flags: approval-comm-release?
Comment on attachment 8783958 [details] [diff] [review] 1297379-websense.patch a=me for c-r
Attachment #8783958 - Flags: approval-comm-release? → approval-comm-release+
Depends on: 1297534
Keywords: leave-open
Whiteboard: [leave open]
Attached patch 1297379-websense-backout.patch (deleted) — — Splinter Review
[Approval Request Comment] Regression caused by (bug #): 1294650 and 1298157 User impact if declined: Windows build fails Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): none String changes made by this patch: none.
Attachment #8787743 - Flags: review?(philip.chee)
Attachment #8787743 - Flags: review?(iann_bugzilla)
Attachment #8787743 - Flags: approval-comm-release?
Attachment #8787743 - Flags: approval-comm-beta?
Attachment #8787743 - Flags: approval-comm-aurora?
Comment on attachment 8787743 [details] [diff] [review] 1297379-websense-backout.patch a/r=me
Attachment #8787743 - Flags: review?(iann_bugzilla)
Attachment #8787743 - Flags: review+
Attachment #8787743 - Flags: approval-comm-release?
Attachment #8787743 - Flags: approval-comm-release+
Attachment #8787743 - Flags: approval-comm-beta?
Attachment #8787743 - Flags: approval-comm-beta+
Attachment #8787743 - Flags: approval-comm-aurora?
Attachment #8787743 - Flags: approval-comm-aurora+
Attachment #8787743 - Flags: review?(philip.chee)
I think we can close the bug for now even with bug 1294650 still open.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 1304434
Blocks: websense
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: