Open
Bug 1297381
Opened 8 years ago
Updated 1 year ago
JAR_MANIFEST processing doesn't write dependencies, runs on every build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: ted, Assigned: sergesanspaille)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is pretty noticeable if you do a top-level no-op `mach build`: https://gist.github.com/6e51e7b622273de16c1bcd36057a663b We don't write any dependency information when we process jar manifests: https://dxr.mozilla.org/mozilla-central/rev/24763f58772d45279a935790f732d80851924b46/config/rules.mk#1185 https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/jar.py The JarMaker class already tracks output files it creates: https://dxr.mozilla.org/mozilla-central/rev/24763f58772d45279a935790f732d80851924b46/python/mozbuild/mozbuild/jar.py#453 So I think it would mostly just need to collect that information into a dependency file, along with any dependencies from preprocessing the manifest file or preprocessing any of the entries.
|
||
Comment 1•8 years ago
|
||
I think the right fix here is to ... not use the jar maker, like the faster make backend does. That's part of my pending stuff for l10n.
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Severity: normal → S3
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D165808
|
||
Updated•2 years ago
|
Attachment #9310418 -
Attachment description: WIP: Bug 1297381 - Have jar.py write its dependencies to avoid rebuild → Bug 1297381 - Have jar.py write its dependencies to avoid rebuild
|
|
||
Updated•2 years ago
|
Assignee: nobody → sguelton
Status: NEW → ASSIGNED
You need to log in
before you can comment on or make changes to this bug.
Description
•