Closed
Bug 1297387
Opened 8 years ago
Closed 2 years ago
Include symbols for test plugins in the crashreporter symbols package on non-Windows
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox51 | --- | affected |
People
(Reporter: ted, Unassigned)
References
Details
bug 1262337 fixed this on Windows, where the symbol dumping code trawls the entire objdir looking for binaries. On other platforms we only dump things under dist/bin, and the test plugins don't get installed there so they don't get picked up. To quote myself from bug 1262337 comment 3:
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> What I would do if I were going to fix this would be to just stop passing in
> the paths to the script, and instead have the script read the binaries.json
> file that is generated nowadays:
> https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/
> binaries.json
>
> That's generated by the build backend from data in moz.build files, so it
> contains every binary the build is going to generate. You'd probably just
> fix Dumper.Process to read that data and iterate over the files it contains:
> https://dxr.mozilla.org/mozilla-central/rev/
> 29d5a4175c8b74f45482276a53985cf2568b4be2/toolkit/crashreporter/tools/
> symbolstore.py#558
>
> You might need to do something to let unit tests override the data. You
> might also need to special-case Mac universal builds, since we dump symbols
> from the stuff in dist/universal for those:
> https://dxr.mozilla.org/mozilla-central/rev/
> 29d5a4175c8b74f45482276a53985cf2568b4be2/Makefile.in#273
>
> I don't know exactly what the right thing to do there is, although
> binaries.json does list where the files should get installed to, so you
> should be able to put together a path relative to dist/universal.
One fiddly thing with this solution is that the libraries generated by the NSS build system are not included in binaries.json right now, but bug 1295937 will fix that.
Reporter | ||
Comment 1•7 years ago
|
||
bug 1337986 might have fixed this. I'll check some build logs + symbol packages.
Reporter | ||
Comment 2•7 years ago
|
||
Ah, no, we still won't dump symbols for things that don't get installed to dist/bin:
https://dxr.mozilla.org/mozilla-central/rev/b266a8d8fd595b84a7d6218d7b8c6b7af0b5027c/config/rules.mk#890
Seems like we could relax that, I don't think the few additional symbol files would be much of a problem.
Comment 3•2 years ago
|
||
This was fixed at some point though I don't remember when
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•