Closed
Bug 1297498
Opened 8 years ago
Closed 8 years ago
Enable source maps in Console by default on Nightly
Categories
(DevTools :: Console, enhancement, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jbhoosreddy, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [source-maps])
Attachments
(1 file)
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
Currently, source maps in console has to be enabled manually in about:config because it is still in its experimental state. This bug is to enable this feature by default only on Nightly, and so we can test it out before we can enable it in for everyone.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → jaideepb
Severity: normal → enhancement
Depends on: 1289570
Whiteboard: [source-maps]
Reporter | ||
Comment 1•8 years ago
|
||
As per Brian's comment in [1], this patch enables source maps in web console in Nightly builds.
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1289570#c4
Attachment #8784107 -
Flags: review?(bgrinstead)
Comment 2•8 years ago
|
||
Comment on attachment 8784107 [details] [diff] [review]
1297498.patch
Review of attachment 8784107 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks! Please do a try push before marking for checkin
Attachment #8784107 -
Flags: review?(bgrinstead) → review+
Reporter | ||
Comment 3•8 years ago
|
||
Reporter | ||
Comment 4•8 years ago
|
||
Reporter | ||
Comment 5•8 years ago
|
||
Reporter | ||
Comment 6•8 years ago
|
||
Updated•8 years ago
|
Priority: -- → P1
Reporter | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 7•8 years ago
|
||
Reporter | ||
Comment 8•8 years ago
|
||
Comment 9•8 years ago
|
||
As per discussion, let's focus on getting sourcemaps working on the client before turning them on in console (first for new debugger frontend, then move that up to toolbox, then have webconsole use the toolbox).
Maybe that will shake out the test failure we've been seeing also
Assignee: jaideepb → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Blocks: source-maps
Comment 10•8 years ago
|
||
The client-side source map service has now landed. So we can now make use of it in the console.
toolbox.sourceMapService will get you the service.
Comment 11•8 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #10)
> The client-side source map service has now landed. So we can now make use of
> it in the console.
> toolbox.sourceMapService will get you the service.
Yes, definitely agree.
I am updating the blocking field.
Honza
Blocks: enable-new-console
Updated•8 years ago
|
No longer blocks: enable-new-console
Comment 12•8 years ago
|
||
This was fixed by bug 1359144, which changed the console to use client-side source maps.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•