Nicolas Silva [:nical] Reporter
	Description • 8 years ago

This type of code:

> if (cond)
>   foo();
>   return;

Is very bad, and is caught by gcc as a warning, at least in the version of gcc installed by default in the current fedora, with the -Wmisleading-indentation warning.

We should not let this type of thing land. I hope that which ever version of the compiler we use on try has the same warning so that we can turn it into an error.

	Nicolas Silva [:nical] Reporter
	Comment 1 • 8 years ago

The warning was introduced with gcc6 and there's clang bug open here https://llvm.org/bugs/show_bug.cgi?id=23910 so it looks like clang does not have it yet.

	Mike Hommey [:glandium]
	Comment 2 • 8 years ago

and we're not building with gcc 6.

	Chris Peterson [:cpeterson]
	Comment 3 • 6 years ago

We are now using gcc 6.1 and -Wmisleading-indentation is enabled by -Wall. clang doesn't support the -Wmisleading-indentation flag, but clang-tidy does a similar indentation check:

https://clang.llvm.org/extra/clang-tidy/checks/readability-misleading-indentation.html

	Sylvestre Ledru [:Sylvestre]
	Comment 4 • 6 years ago

Which is enabled at dev / review phease:
https://dxr.mozilla.org/mozilla-central/source/tools/clang-tidy/config.yaml#76