Closed Bug 1297652 Opened 8 years ago Closed 3 years ago

Revert jit-test workaround for Windows/NSPR threading issues

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

(Keywords: triage-deferred)

Attachments

(4 files)

Patch
(deleted), patch
fitzgen
: review+
Details | Diff | Splinter Review
Bug 1297652 part 1 - Revert jit-test workaround for Windows/NSPR threading issues. r?iain!
(deleted), text/x-phabricator-request
Details
Bug 1297652 part 2 - Fix auto-formatted code to be more readable. r?iain!
(deleted), text/x-phabricator-request
Details
Bug 1297652 part 3 - Remove another Windows-specific workaround. r?iain!
(deleted), text/x-phabricator-request
Details
The patch for bug 970063 made us ignore test timeouts on some Windows versions due to a Windows bug we hit with NSPR threads (see bug 970063 comment 7).
Attached patch Patch (deleted) — — Splinter Review
Attachment #8784305 - Flags: review?(nfitzgerald)
Attachment #8784305 - Flags: review?(nfitzgerald) → review+
Just wondering, is this ready for landing?
Flags: needinfo?(jdemooij)
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c9882472df Remove jit-test workaround for Windows/NSPR threading issues. r=fitzgen
(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #2) > Just wondering, is this ready for landing? Sorry for the delay. I have a bit of a backlog atm, will push more stuff this week.
Flags: needinfo?(jdemooij)
Bah, I backed this out because it makes Windows CGC jobs timeout. We just need to add more tests to the slow-tests-with-CGC file I guess.
Keywords: leave-open
Backout by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d68d4884890 Backed out changeset c1c9882472df for cgc timeouts.
Keywords: triage-deferred
Priority: -- → P3
The leave-open keyword is there and there is no activity for 6 months. :jandem, maybe it's time to close this bug?
Flags: needinfo?(jdemooij)
(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #7) > The leave-open keyword is there and there is no activity for 6 months. > :jandem, maybe it's time to close this bug? Nope, we still want to fix this.
Flags: needinfo?(jdemooij)

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)

When this last landed (5 years ago), it was backed out because some slow tests caused
timeouts. The SM Windows CI builds now run on Windows Server 2012, which has kernel
version 6.2, so shouldn't be affected by this workaround for versions 6.0 and 6.1.

Attachment #9255026 - Attachment description: Bug 1297652 - Revert jit-test workaround for Windows/NSPR threading issues. r?iain! → Bug 1297652 part 1 - Revert jit-test workaround for Windows/NSPR threading issues. r?iain!

This bug might have been related to the other (NSPR) issue, or maybe it only affected
Windows 7 to begin with. We can easily add this back if it still happens.

Depends on D133647

Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a8a683341db part 1 - Revert jit-test workaround for Windows/NSPR threading issues. r=iain https://hg.mozilla.org/integration/autoland/rev/6e95dc63f3d2 part 2 - Fix auto-formatted code to be more readable. r=iain
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7285a00652cd part 3 - Remove another Windows-specific workaround. r=iain
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
status-firefox97: --- → fixed
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: