David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Description • 8 years ago

When the GPU process crashes, we should have a doorhanger/notification like content does so the user can submit a crash report. We also need to make sure Socorro will recognize these crash reports.

Note: We can't (easily) use PCrashReporter in the GPU process because its Parent/Child relationship is inverted with respect to GPUChild/GPUParent. That's why this is blocked on bug 1278717.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 1 • 8 years ago

This builds on bug 1278717 (which adds support for taking minidumps+metadata) and also adds crash service support. I don't know this code very well so I'm not sure what else might need to be done.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 2 • 8 years ago

Note: going to file a separate bug for UI.

	Georg Fritzsche [:gfritzsche]
	Comment 3 • 8 years ago

Comment on attachment 8797942 [details] [diff] [review]
patch

I don't think i have good context for the crash reporting service right now, although i can try to review as a fallback.

Ted, are you still actively reviewing for this?

	Georg Fritzsche [:gfritzsche]
	Comment 4 • 8 years ago

David, heads-up for those new crash types coming up. This might be relevant to your teams work.

	(not currently active) Ted Mielczarek
	Comment 5 • 8 years ago

Comment on attachment 8797942 [details] [diff] [review]
patch

Review of attachment 8797942 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/crashes/nsICrashService.idl
@@ +22,5 @@
>    const long PROCESS_TYPE_MAIN = 0;
>    const long PROCESS_TYPE_CONTENT = 1;
>    const long PROCESS_TYPE_PLUGIN = 2;
>    const long PROCESS_TYPE_GMPLUGIN = 3;
> +  const long PROCESS_TYPE_GPU = 4;

It might be time to put an explanatory comment above each of these...

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 6 • 8 years ago

Bleh. I had checked this in under the wrong bug #. Should be:

https://hg.mozilla.org/mozilla-central/rev/c8183800343e