Closed
Bug 1298110
Opened 8 years ago
Closed 8 years ago
Add BoGo TLS tests to CI
Categories
(NSS :: Test, defect)
NSS
Test
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: franziskus, Assigned: franziskus)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
We should run the BoGo TLS tests on CI.
Unfortunately, they fail intermittently at the moment.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → franziskuskiefer
|
||
Comment 1•8 years ago
|
||
Mostly your patch, but it has a few changes.
Attachment #8792104 -
Flags: review?(franziskuskiefer)
|
|
||
Updated•8 years ago
|
Attachment #8784925 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8792104 [details] [diff] [review]
0001-Bug-1298110-Add-BoGo-TLS-tests-to-Taskcluster.patch
Review of attachment 8792104 [details] [diff] [review]:
-----------------------------------------------------------------
::: tests/bogo/bogo.sh
@@ +50,5 @@
> +bogo_init
> +exec 3>&1
> +BOGO_OUT=$(GOPATH=$PWD go test -pipe -shim-path "${BINDIR}"/nss_bogo_shim -loose-errors -allow-unimplemented -shim-config "${SOURCE_DIR}external_tests/nss_bogo_shim/config.json" 2>&1 1>&3)
> +exec 3>&-
> +BOGO_OUT=`echo $BOGO_OUT | grep FAILED`
we should do something like BOGO_OUT=`echo $BOGO_OUT | grep -i 'FAILED\|Assertion failure'` here to make sure we catch assertion failures (not sure if we could use return codes here, that didn't work for other tests).
Attachment #8792104 -
Flags: review?(franziskuskiefer) → review+
|
|
||
Comment 3•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•8 years ago
|
||
|
|
Assignee | |
Comment 5•8 years ago
|
||
bump bogo to draft 16 and enable tests: https://hg.mozilla.org/projects/nss/rev/2afa2e8341850f694a032e7ed6fc8751a498e7a5
You need to log in
before you can comment on or make changes to this bug.
Description
•