Sylvestre Ledru [:Sylvestre] Assignee
	Description • 8 years ago

+++ This bug was initially created as a clone of Bug #1295934 +++
Coverity says "Missing comma in a string array initialization (MISSING_COMMA)"

https://hg.mozilla.org/mozilla-central/rev/813bce8554d1#l1.19

	Nicholas Nethercote [inactive]
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8785715 [details]
Bug 1298701 - Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure

https://reviewboard.mozilla.org/r/74798/#review72632

Thanks for catching! My first reaction was "how could the compiler allow that?" and then I realized "Oh, C strings..."

	Nicholas Nethercote [inactive]
	Comment 4 • 8 years ago
mozreview-review

Comment on attachment 8785715 [details]
Bug 1298701 - Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure

https://reviewboard.mozilla.org/r/74798/#review72634

	Sylvestre Ledru [:Sylvestre] Assignee
	Comment 5 • 8 years ago

Coverity found it. We will see if we can introduce a static analyzer check for this.

	Pulsebot
	Comment 6 • 8 years ago

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29179e545070
Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure r=njn

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/29179e545070