In BrowserProvider.query(), most of the database queries are handled in a large switch(match) statement. The TOPSITES query is handled separately, at the beginning of this method: the reason for this is that the TOPSITES query requires a writable database (because of the temporary tables), whereas all the other queries are happy with a readable database: we handle TOPSITES specially and let it obtain a writable DB itself, for the other queries we obtain the readable DB within query() and then pass that readable DB to the query methods within the switch. See: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java?q=BrowserProvider.java&redirect_type=direct# We should add a comment explaining this directly to BrowserProvider.java.

Removing an erroneously added dependency (that was meant for another bug)/

Blocking on Bug 1293710 so I don't cause unnecessary merge conflicts!

Comment on attachment 8788537 [details] Bug 1298968 - Add comment explaining why TOPSITES is handled outside of switch https://reviewboard.mozilla.org/r/76998/#review75130

Pushed by ahunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/243fe9c65a04 Add comment explaining why TOPSITES is handled outside of switch r=sebastian