Clicking on TopSites does nothing right now. We need to: 1 - add OnUrlOpenListener plumbing to ActivityStream 2 - hook the topsites view up to open pages when selected

Comment on attachment 8786907 [details] Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter https://reviewboard.mozilla.org/r/75780/#review73922 ::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:22 (Diff revision 1) > -import org.mozilla.gecko.home.HomeFragment; > -import org.mozilla.gecko.home.HomeScreen; > import org.mozilla.gecko.home.SimpleCursorLoader; > import org.mozilla.gecko.home.activitystream.topsites.TopSitesPagerAdapter; > > public class ActivityStream extends FrameLayout { Unrelated: Didn't we want to rename this so that we do not have two classes named "ActivityStream"? ::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:40 (Diff revision 1) > RecyclerView rv = (RecyclerView) findViewById(R.id.activity_stream_main_recyclerview); > > - // TODO: we need to retrieve BrowserApp and pass it in as onUrlOpenListener. That will > - // be simpler once we're a HomeFragment, but isn't so simple while we're still a View. > - adapter = new StreamRecyclerAdapter(lm, null); > rv.setAdapter(adapter); > rv.setLayoutManager(new LinearLayoutManager(getContext())); > rv.setHasFixedSize(true); Can't you do those assignments in the constructor too? inflate() should return the inflated view on which you can call findViewById().

Comment on attachment 8786908 [details] Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter https://reviewboard.mozilla.org/r/75782/#review73930

https://hg.mozilla.org/integration/fx-team/rev/35b31a0d906aa6d618feb11592aaa5aec924db49 Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter r=sebastian https://hg.mozilla.org/integration/fx-team/rev/3d376f300eac2ed52d331a47b4608c7719013bae Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter r=sebastian

https://hg.mozilla.org/mozilla-central/rev/35b31a0d906a https://hg.mozilla.org/mozilla-central/rev/3d376f300eac