:Paolo Amadini Reporter
	Description • 8 years ago

[Tracking Requested - why for this release]:
This is a regression from bug 1206233 part 4.

In the Application Menu, when you open a subview that is taller than the main view, typically the History view, the footer of the main view does not move to the bottom.

	:Paolo Amadini Reporter
	Comment 1 • 8 years ago

Florian, can you just back out part 4? We accepted the flickering for the Downloads Panel, but I also remember you had an alternate fix for the flickering of the Control Center, so maybe you want to implement that solution on top of the backout.

	Florian Quèze [:florian] Assignee
	Comment 2 • 8 years ago

I had an alternate fix (attachment 8776953 [details] [diff] [review]) that Jared r-'ed because it was a hack.

Also, I don't find this bug to be worse than the flickering; I hadn't noticed it until you told me precisely where I needed to look.

	:Paolo Amadini Reporter
	Comment 3 • 8 years ago

(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> I had an alternate fix (attachment 8776953 [details] [diff] [review]) that
> Jared r-'ed because it was a hack.

Maybe we should take that fix now, until we land the new resizing architecture.

> Also, I don't find this bug to be worse than the flickering; I hadn't
> noticed it until you told me precisely where I needed to look.

This bug applies to most users using the History view. I guess this view is more commonly used on Windows where the History menu is hidden by default. The flickering instead would apply to fewer situations.

	Marcia Knous [:marcia]
	Comment 4 • 8 years ago

Tracking 51+ since this affects Windows users.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 5 • 8 years ago

Yeah, I'm fine with the hack since we're making progress on the real fix.

	Florian Quèze [:florian] Assignee
	Comment 6 • 8 years ago

This is an unbitrotted backout of attachment 8777777 [details] [diff] [review] + attachment 8776953 [details] [diff] [review] unbitrotted + additional hackery for compatibility with the changes from bug 1206229. At this point I really hope this is temporary...

	Jared Wein [:jaws] (please needinfo? me)
	Comment 7 • 8 years ago

Comment on attachment 8789468 [details] [diff] [review]
Patch

Review of attachment 8789468 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but we need to get some better fixes. I hope bug 1009116 will fix this.

::: browser/components/controlcenter/content/panel.inc.xul
@@ +90,5 @@
>            <label id="identity-popup-permissions-headline"
>                   class="identity-popup-headline"
>                   value="&identity.permissions;"/>
>            <vbox id="identity-popup-permission-list"/>
> +          <description id="identity-popup-permission-reload-hint">&identity.permissionsReloadHint;</description>

Why does the order of the <description> elements here need to be swapped?

	Florian Quèze [:florian] Assignee
	Comment 8 • 8 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)

> >            <vbox id="identity-popup-permission-list"/>
> > +          <description id="identity-popup-permission-reload-hint">&identity.permissionsReloadHint;</description>
> 
> Why does the order of the <description> elements here need to be swapped?

Because the hack takes the height from this._permissionList.nextSibling

	Jared Wein [:jaws] (please needinfo? me)
	Comment 9 • 8 years ago

Okay, thanks for the quick response!

	Florian Quèze [:florian] Assignee
	Comment 10 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/05bab13e18504f8c0b69076c10e0ef6a6df29333
Bug 1299437 - Manually calculate height changes of the control center's permission list until we have a real fix for sizing issues in panelmultiview, r=jaws.

	Florian Quèze [:florian] Assignee
	Comment 11 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/b09dd5013cefe5d66700ca0d25ceaf821509069e
Bug 1299437 - follow-up to fix browser_permissions.js bustage, r=bustage-fix.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/05bab13e1850
https://hg.mozilla.org/mozilla-central/rev/b09dd5013cef

	Adrian Florinescu [:aflorinescu]
	Comment 13 • 8 years ago

verified as fixed on Aurora 51.0a2 - 20160920004004