Closed Bug 1299490 Opened 8 years ago Closed 8 years ago

"aggregates=submissions" in URL is not honored

Categories

(Data Platform and Tools :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ayg, Assigned: aalmutairi15, Mentored)

Details

(Whiteboard: [good first bug] [lang=js] [measurement:client])

Well that's pretty cool. Looks like we have a too-aggressive filter right here: https://github.com/mozilla/telemetry-dashboard/blob/gh-pages/new-pipeline/src/dashboards.js#L230 Just need to add submissions to that list and that'll be that.
Mentor: chutten
Priority: -- → P3
Whiteboard: [good first bug] [lang=js]
Hi, I would like to work on this bug. Thanks
Awesome! I have assigned the bug to you. If you have any questions, please do not hesitate to ask.
Assignee: nobody → aalmutairi15
Status: NEW → ASSIGNED
Whiteboard: [good first bug] [lang=js] → [good first bug] [lang=js] [measurement:client]
Hi Chris, we were using mercurial and a plugin to make it work with git for the clone. We were wondering how you want us to submit the patch, or where can we find that information? Thanks
We have a guide for that! https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch Please let me know if anything in those instructions are unclear or if you require assistance.
Hi Chris What do we suppose to put in the following editor? because it doesn't like any of what we type. Bug: 1299490 Attachment Description: update Reviewers: <none> Feedback: <none> Attachment Comment (appears as a regular comment on the bug): <update> ----- END Attachment Comment ----
(In reply to Ahmed Almutairi from comment #6) > Hi Chris > > What do we suppose to put in the following editor? because it doesn't like > any of what we type. > > > Bug: 1299490 > Attachment filename: . > Attachment Description: update > Reviewers: <none> > Feedback: <none> > Attachment Comment (appears as a regular comment on the bug): <update> > > ----- END Attachment Comment ----
Oh, goodness, I just realize I gave you completely the wrong advice. This isn't for mozilla-central, this is for a github repository. I apologize. Github repositories have their own workflow. The short version is: 0. Acquire and log in to a github account 1. Go to mozilla/telemetry-dashboard and click "Fork this repository" 2. Clone your forked repository (looks like you already cloned mozilla/telemetry-dashboard. You can likely just add your fork as a remote to your existing repository without having to re-download anything) 3. Push your changes to your fork 4. In the github webpage for your fork, create and submit a Pull Request (add me as a reviewer) At that point I will receive an email letting me know your code is awaiting review and from there we can work through getting it merged into production.
Hi Chris we have submitted it with my friends name Aaron. Did you get it? Thanks.
Sure did, thanks! (https://github.com/mozilla/telemetry-dashboard/pull/309) Just one more testing step before we push this to production.
The change has been merged and should be live soon. (To see when it becomes live, try loading https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=median!submissions&cumulative=0&end_date=null&keys=&max_channel_version=nightly%252F55&measure=GC_MS&min_channel_version=nightly%252F52&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=null&trim=1&use_submission_date=0 (or https://mzl.la/2qKqzi9) and see if it shows submissions and median aggregates.) Thank you for your contribution! Do you need help finding the next thing to work on, or do you have an eye on something specific?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Webtools → Data Platform and Tools
Component: Telemetry Dashboards (TMO) → General
You need to log in before you can comment on or make changes to this bug.